mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Michael Krufky <mkrufky@linuxtv.org>
Cc: "José Suárez" <j.suarez.agapito@gmail.com>,
	linux-dvb@linuxtv.org,
	"Mauro Carvalho Chehab" <mchehab@infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"pasky@ucw.cz" <pasky@ucw.cz>
Subject: Re: [linux-dvb] Avermedia 777 misbehaves after remote hack merged into v4l-dvb tree
Date: Mon, 13 Nov 2006 08:44:16 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0611130842010.22714@g5.osdl.org> (raw)
In-Reply-To: <45589E2E.7070304@linuxtv.org>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1025 bytes --]



On Mon, 13 Nov 2006, Michael Krufky wrote:
> 
> Mauro -- that patch needs fixing / more testing before it goes to mainstream...
> 
> Could you please remove that changeset from your git tree before Linus pulls it?

Too late. Already pulled and pushed out.

Looking at the patch, one obvious bug stands out: the new case statement 
for SAA7134_BOARD_AVERMEDIA_777 doesn't have a "break" at the end.

José, can you test this trivial patch and see if it fixes things?

		Linus

---
diff --git a/drivers/media/video/saa7134/saa7134-input.c b/drivers/media/video/saa7134/saa7134-input.c
index 7f62403..dee8355 100644
--- a/drivers/media/video/saa7134/saa7134-input.c
+++ b/drivers/media/video/saa7134/saa7134-input.c
@@ -202,6 +202,7 @@ int saa7134_input_init1(struct saa7134_d
 		/* Without this we won't receive key up events */
 		saa_setb(SAA7134_GPIO_GPMODE1, 0x1);
 		saa_setb(SAA7134_GPIO_GPSTATUS1, 0x1);
+		break;
 	case SAA7134_BOARD_KWORLD_TERMINATOR:
 		ir_codes     = ir_codes_pixelview;
 		mask_keycode = 0x00001f;

  reply	other threads:[~2006-11-13 16:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200611131711.46626.j.suarez.agapito@gmail.com>
2006-11-13 16:32 ` Michael Krufky
2006-11-13 16:44   ` Linus Torvalds [this message]
2006-11-13 21:09     ` Michael Krufky
2006-11-13 21:23       ` Mauro Carvalho Chehab
2006-11-14  3:45         ` José Suárez
2006-11-14  4:28           ` Petr Baudis
2006-11-13 21:17     ` Petr Baudis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0611130842010.22714@g5.osdl.org \
    --to=torvalds@osdl.org \
    --cc=j.suarez.agapito@gmail.com \
    --cc=linux-dvb@linuxtv.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=mkrufky@linuxtv.org \
    --cc=pasky@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®