mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
Cc: mingo@elte.hu, nickpiggin@yahoo.com.au, akpm@osdl.org,
	linux-kernel@vger.kernel.org, kenneth.w.chen@intel.com
Subject: Re: [patch] sched: decrease number of load balances
Date: Mon, 20 Nov 2006 16:39:03 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0611201625240.23868@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20061120142633.A17305@unix-os.sc.intel.com>

On Mon, 20 Nov 2006, Siddha, Suresh B wrote:

> +		if (local_group && balance_cpu != this_cpu && balance) {
								^^^^^

This would need to be *balance right? balance is always != 0.

> +			*balance = 0;
> +			goto ret;
> +		}

How well was this patch tested?

We already have idle processors pulling processes from elsewhere in the 
system. Load balancing on an idle processor could only replicate the 
balance on idle logic.



  reply	other threads:[~2006-11-21  0:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-20 22:26 Siddha, Suresh B
2006-11-21  0:39 ` Christoph Lameter [this message]
2006-11-21  0:43   ` Siddha, Suresh B
2006-11-21  1:39     ` Christoph Lameter
2006-11-21  1:54       ` Siddha, Suresh B

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0611201625240.23868@schroedinger.engr.sgi.com \
    --to=clameter@sgi.com \
    --cc=akpm@osdl.org \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nickpiggin@yahoo.com.au \
    --cc=suresh.b.siddha@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®