From: Hugh Dickins <hugh@veritas.com>
To: d binderman <dcb314@hotmail.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: mm/fremap.c(104): remark #593: variable "pte_val" was set but never used
Date: Tue, 28 Nov 2006 18:01:44 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0611281757150.32539@blonde.wat.veritas.com> (raw)
In-Reply-To: <BAY107-F24D4E1EDA745C0EBACC9139CE60@phx.gbl>
On Mon, 27 Nov 2006, d binderman wrote:
>
> I just tried to compile Linux kernel 2.6.18.3 with the Intel C
> C compiler.
>
> The compiler said
>
> mm/fremap.c(104): remark #593: variable "pte_val" was set but never used
>
> The source code is
>
> pte_t pte_val;
>
> I have checked the source code and I agree with the compiler.
> Suggest delete local variable.
You're right, thank you, here's a patch...
[PATCH] kill install_file_pte's pte_val
David Binderman and his Intel C compiler rightly observe that
install_file_pte no longer has any use for its pte_val.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
mm/fremap.c | 2 --
1 file changed, 2 deletions(-)
--- 2.6.19-rc6/mm/fremap.c 2006-11-16 08:22:25.000000000 +0000
+++ linux/mm/fremap.c 2006-11-28 17:50:47.000000000 +0000
@@ -101,7 +101,6 @@ int install_file_pte(struct mm_struct *m
{
int err = -ENOMEM;
pte_t *pte;
- pte_t pte_val;
spinlock_t *ptl;
pte = get_locked_pte(mm, addr, &ptl);
@@ -114,7 +113,6 @@ int install_file_pte(struct mm_struct *m
}
set_pte_at(mm, addr, pte, pgoff_to_pte(pgoff));
- pte_val = *pte;
/*
* We don't need to run update_mmu_cache() here because the "file pte"
* being installed by install_file_pte() is not a real pte - it's a
prev parent reply other threads:[~2006-11-28 18:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-27 12:35 d binderman
2006-11-28 18:01 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0611281757150.32539@blonde.wat.veritas.com \
--to=hugh@veritas.com \
--cc=akpm@osdl.org \
--cc=dcb314@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®