mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: proposed patch:  standardize white space for "#endif /* __KERNEL__ */" directives
Date: Sat, 2 Dec 2006 08:32:54 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0612020823330.17876@localhost.localdomain> (raw)


  i've got a one-line perl command that runs through include/linux and
standardizes all of the "#endif" directives for "__KERNEL__" into a
single variant

#endif /* __KERNEL__ */

where all of the whitespace bits above are a single space and nothing
more.

  while this is clearly just aesthetic and involves only whitespace
transformation, it was handy when i was messing around with what
happened during "make headers_install" as i was trying to match the
opening and closing __KERNEL__ directives, and i had to accommodate
that some of those #endif directives had a space, and others a tab, or
multiple spaces, or multiple tabs, etc.  grrrrrrrrrr.

  is it worth submitting this kind of whitespace-related patch?
obviously, it can be done for the entire tree (perhaps in a multi-part
patch) or just include/linux where i was using it.

  if that goes in, a follow-up patch would add any missing __KERNEL__
comments to the corresponding #endif directives so that, visually, it
would be far easier to see the nesting.

  thoughts?  or a waste of time?

rday

p.s.  there is the occasional

#endif    // __KERNEL__

directive as well, but that's obviously just as easy to handle.

                 reply	other threads:[~2006-12-02 13:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0612020823330.17876@localhost.localdomain \
    --to=rpjday@mindspring.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®