Re: [PATCH 2.6.19] m68k: replace kmalloc+memset with kzalloc

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Sat, 2 Dec 2006, Yan Burman wrote:
> Replace kmalloc+memset with kzalloc 
> 
> Signed-off-by: Yan Burman <burman.yan@gmail.com>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

> diff -rubp linux-2.6.19-rc5_orig/arch/m68k/amiga/chipram.c linux-2.6.19-rc5_kzalloc/arch/m68k/amiga/chipram.c
> --- linux-2.6.19-rc5_orig/arch/m68k/amiga/chipram.c	2006-11-09 12:16:21.000000000 +0200
> +++ linux-2.6.19-rc5_kzalloc/arch/m68k/amiga/chipram.c	2006-11-11 22:44:04.000000000 +0200
> @@ -52,10 +52,9 @@ void *amiga_chip_alloc(unsigned long siz
>  #ifdef DEBUG
>      printk("amiga_chip_alloc: allocate %ld bytes\n", size);
>  #endif
> -    res = kmalloc(sizeof(struct resource), GFP_KERNEL);
> +    res = kzalloc(sizeof(struct resource), GFP_KERNEL);
>      if (!res)
>  	return NULL;
> -    memset(res, 0, sizeof(struct resource));
>      res->name = name;
>  
>      if (allocate_resource(&chipram_res, res, size, 0, UINT_MAX, PAGE_SIZE, NULL, NULL) < 0) {
> 
> diff -rubp linux-2.6.19-rc5_orig/arch/m68k/atari/hades-pci.c linux-2.6.19-rc5_kzalloc/arch/m68k/atari/hades-pci.c
> --- linux-2.6.19-rc5_orig/arch/m68k/atari/hades-pci.c	2006-11-09 12:16:21.000000000 +0200
> +++ linux-2.6.19-rc5_kzalloc/arch/m68k/atari/hades-pci.c	2006-11-11 22:44:04.000000000 +0200
> @@ -375,10 +375,9 @@ struct pci_bus_info * __init init_hades_
>  	 * Allocate memory for bus info structure.
>  	 */
>  
> -	bus = kmalloc(sizeof(struct pci_bus_info), GFP_KERNEL);
> +	bus = kzalloc(sizeof(struct pci_bus_info), GFP_KERNEL);
>  	if (!bus)
>  		return NULL;
> -	memset(bus, 0, sizeof(struct pci_bus_info));
>  
>  	/*
>  	 * Claim resources. The m68k has no separate I/O space, both
> 
> 
> 

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds