From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032093AbWLGMEU (ORCPT ); Thu, 7 Dec 2006 07:04:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1032094AbWLGMEU (ORCPT ); Thu, 7 Dec 2006 07:04:20 -0500 Received: from nic.NetDirect.CA ([216.16.235.2]:46003 "EHLO rubicon.netdirect.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032093AbWLGMET (ORCPT ); Thu, 7 Dec 2006 07:04:19 -0500 X-Originating-Ip: 74.102.209.62 Date: Thu, 7 Dec 2006 06:59:52 -0500 (EST) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Linux kernel mailing list Subject: [PATCH] kbuild : Make Fusion MPT selectable from "Device drivers" menu Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Net-Direct-Inc-MailScanner-Information: Please contact the ISP for more information X-Net-Direct-Inc-MailScanner: Found to be clean X-Net-Direct-Inc-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-16.8, required 5, ALL_TRUSTED -1.80, BAYES_00 -15.00) X-Net-Direct-Inc-MailScanner-From: rpjday@mindspring.com Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Rewrite the Fusion MPT Kconfig file so that all of MPT functionality is entirely selectable from "Device drivers." Signed-off-by: Robert P. J. Day --- The original Kconfig file seems to have an odd structure, as you can see from the first part of the file: ======================================================== menu "Fusion MPT device support" config FUSION bool default n config FUSION_SPI tristate "Fusion MPT ScsiHost drivers for SPI" depends on PCI && SCSI select FUSION select SCSI_SPI_ATTRS ... ======================================================== note how the majority of entries in that file don't directly *depend* on FUSION. instead, they depend on *external* config variables, and *select* FUSION, and this is not the only place i've noticed that kind of dependency wording. is that a regular feature? having that structure certainly makes it slightly more difficult to rewrite the menu entries, and it's not clear there's any obvious advantage to doing it that way. diff --git a/drivers/message/fusion/Kconfig b/drivers/message/fusion/Kconfig index ea31d84..b2da14d 100644 --- a/drivers/message/fusion/Kconfig +++ b/drivers/message/fusion/Kconfig @@ -1,14 +1,12 @@ - -menu "Fusion MPT device support" - -config FUSION - bool +menuconfig FUSION + bool "Fusion MPT device support" default n +if FUSION + config FUSION_SPI tristate "Fusion MPT ScsiHost drivers for SPI" depends on PCI && SCSI - select FUSION select SCSI_SPI_ATTRS ---help--- SCSI HOST support for a parallel SCSI host adapters. @@ -23,7 +21,6 @@ config FUSION_SPI config FUSION_FC tristate "Fusion MPT ScsiHost drivers for FC" depends on PCI && SCSI - select FUSION select SCSI_FC_ATTRS ---help--- SCSI HOST support for a Fiber Channel host adapters. @@ -40,7 +37,6 @@ config FUSION_FC config FUSION_SAS tristate "Fusion MPT ScsiHost drivers for SAS" depends on PCI && SCSI - select FUSION select SCSI_SAS_ATTRS ---help--- SCSI HOST support for a SAS host adapters. @@ -100,4 +96,4 @@ config FUSION_LAN If unsure whether you really want or need this, say N. -endmenu +endif