mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Cc: trivial@kernel.org
Subject: [PATCH] init: Remove commented, obsolete code invoking smp_commence().
Date: Thu, 14 Dec 2006 14:39:07 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0612141433050.7079@localhost.localdomain> (raw)


  Remove the "#if 0"ed call to smp_commence, which is clearly
obsolete.

Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

---

  There appears to be no value to leaving that call in the code, given
that the source file "arch/ia64/kernel/smpboot.c" explains:

  "Switch over to hotplug-CPU boot-sequence.
smp_boot_cpus()/smp_commence() is replaced by
smp_prepare_cpus()/__cpu_up()/smp_cpus_done()."

diff --git a/init/main.c b/init/main.c
index e3f0bb2..a148039 100644
--- a/init/main.c
+++ b/init/main.c
@@ -397,11 +397,6 @@ static void __init smp_init(void)
 	/* Any cleanup work */
 	printk(KERN_INFO "Brought up %ld CPUs\n", (long)num_online_cpus());
 	smp_cpus_done(max_cpus);
-#if 0
-	/* Get other processors into their bootup holding patterns. */
-
-	smp_commence();
-#endif
 }

 #endif

                 reply	other threads:[~2006-12-14 19:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0612141433050.7079@localhost.localdomain \
    --to=rpjday@mindspring.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®