Re: lots of code could be simplified by using ARRAY_SIZE()

["Robert P. J. Day" <rpjday@mindspring.com>]

On Sun, 17 Dec 2006, Randy Dunlap wrote:

> On Sun, 17 Dec 2006 13:13:59 -0500 (EST) Robert P. J. Day wrote:
>
> >
> >   so here's the end result of my experiment to replace unnecessary
> > code snippets with an invocation of the ARRAY_SIZE() macro from
> > include/linux/kernel.h.  i've attached the script that i ran on the
> > entire tree, then (after adding al viro's connector patch), did:
> >
> >   $ make allyesconfig	# for the stress factor
> >   $ make
> >
> > to see what would happen.
> >
> >   amazingly, the compile worked all the way down to:
> >
> >   AS      arch/i386/boot/bootsect.o
> >   LD      arch/i386/boot/bootsect
> >   AS      arch/i386/boot/setup.o
> >   LD      arch/i386/boot/setup
> >   AS      arch/i386/boot/compressed/head.o
> >   CC      arch/i386/boot/compressed/misc.o
> >   OBJCOPY arch/i386/boot/compressed/vmlinux.bin
> >   HOSTCC  arch/i386/boot/compressed/relocs
> > arch/i386/boot/compressed/relocs.c: In function 'sym_type':
> > arch/i386/boot/compressed/relocs.c:72: warning: implicit declaration of function 'ARRAY_SIZE'
>
> That's a userspace program and shouldn't use kernel.h.

ah, quite right, my bad.  eggnog hangover.

rday