From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Erik Mouw <erik@harddisk-recovery.com>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Add a new section to CodingStyle, promoting include/linux/kernel.h.
Date: Mon, 18 Dec 2006 16:54:53 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.0612181652140.8141@localhost.localdomain> (raw)
In-Reply-To: <20061218215002.GL7280@harddisk-recovery.com>
On Mon, 18 Dec 2006, Erik Mouw wrote:
> On Mon, Dec 18, 2006 at 12:43:35PM -0500, Robert P. J. Day wrote:
> > Add a new section to the CodingStyle file, encouraging people not to
> > re-invent available kernel macros such as ARRAY_SIZE(),
> > FIELD_SIZEOF(), min() and max(), among others.
>
> Good stuff. Could you also mention the printk() KERN_ALERT etc.
> levels? I've seen quite some people using "<1>" on the kernelnewbies
> list.
they may be using it on that list, but there's very little of that in
the kernel source itself. this is the only example i found:
$ grep -r '<[0-7]>' * | grep printk
arch/ppc/syslib/m8260_pci_erratum9.c: printk("<4>Using IDMA%d for MPC8260 device erratum PCI 9 workaround\n",
maybe i'll submit a patch to clean that one up.
rday
prev parent reply other threads:[~2006-12-18 21:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-18 17:43 Robert P. J. Day
2006-12-18 17:57 ` Randy Dunlap
2006-12-18 20:18 ` Jan Engelhardt
2006-12-18 21:50 ` Erik Mouw
2006-12-18 21:54 ` Robert P. J. Day [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0612181652140.8141@localhost.localdomain \
--to=rpjday@mindspring.com \
--cc=akpm@osdl.org \
--cc=erik@harddisk-recovery.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®