From: "Robert P. J. Day" <rpjday@mindspring.com>
To: David Rientjes <rientjes@cs.washington.edu>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Get rid of most of the remaining k*alloc() casts.
Date: Tue, 19 Dec 2006 15:11:37 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.0612191505370.11728@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64N.0612191158300.21721@attu4.cs.washington.edu>
On Tue, 19 Dec 2006, David Rientjes wrote:
> On Tue, 19 Dec 2006, Robert P. J. Day wrote:
>
> > that sounds reasonable but, as i've mentioned before, many of the
> > sizable cleanups i've submitted are produced by a simple script,
> > which is written to process *one* kind of cleanup. if i tried to
> > fix everything else in the same area at the same time, *that*
> > would involve far more manual labour, not to mention that the
> > patch would be less well-defined, and the probability of a fatal
> > typo would actually increase.
> If these cleanups are being generated by a simple script, I would
> suggest making sure that script works before submitting patches
> which break the kernel.
your point has already been taken. i'm fairly sure i'm going to make
the occasional screwup, someone will point it out in no uncertain
terms, and i'll fix it. and life will continue.
> On the other hand, if that script is only being used to point you in
> the direction of a possible cleanup, then it takes very little
> effort to move an asterisk as one person already suggested, get rid
> of whitespace, or make a kzalloc conversion.
all right, if there's some other cleanup that can be done at the
same spot, then i'll put in the effort to do it, as long as it's
within reason. fair enough?
rday
prev parent reply other threads:[~2006-12-19 20:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-19 11:31 Robert P. J. Day
2006-12-19 15:41 ` Jan Engelhardt
2006-12-19 15:43 ` Robert P. J. Day
2006-12-19 19:25 ` David Rientjes
2006-12-19 19:44 ` Robert P. J. Day
2006-12-19 20:07 ` David Rientjes
2006-12-19 20:11 ` Robert P. J. Day [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0612191505370.11728@localhost.localdomain \
--to=rpjday@mindspring.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@cs.washington.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®