Re: [PATCH] Remove logically superfluous comparisons from Kconfig files.

["Robert P. J. Day" <rpjday@mindspring.com>]

On Wed, 27 Dec 2006, Horst H. von Brand wrote:

> Robert P. J. Day <rpjday@mindspring.com> wrote:
> >   Remove Kconfig comparisons of the form FUBAR || FUBAR=n, since they
> > appear to be superfluous.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> >
> > ---
> >
> >   based on what i read in kconfig-language.txt, it would *appear* that
> > those comparisons are redundant, but i'm willing to be convinced
> > otherwise.  (unless the developer specifically wanted the case of
> > "!=m", which i'm fairly sure is not the same thing, yes?)
>
> Would be clearer written that way if so.
>
> >  drivers/char/drm/Kconfig   |    2 +-
> >  fs/dlm/Kconfig             |    1 -
> >  net/ipv4/netfilter/Kconfig |    1 -
> >  net/sctp/Kconfig           |    1 -
> >  4 files changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/drivers/char/drm/Kconfig b/drivers/char/drm/Kconfig
> > index ef833a1..d681e68 100644
> > --- a/drivers/char/drm/Kconfig
> > +++ b/drivers/char/drm/Kconfig
> > @@ -6,7 +6,7 @@
> >  #
> >  config DRM
> >  	tristate "Direct Rendering Manager (XFree86 4.1.0 and higher DRI support)"
> > -	depends on (AGP || AGP=n) && PCI
> > +	depends on && PCI
>                    ^^ ???

the stuff above is *very* old and also incorrect -- the only
outstanding patch i have in the queue should be to remove the final 3
"depends" directives in Kconfig files, nothing more.

rday