From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?
Date: Fri, 29 Dec 2006 01:16:07 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.0612290106550.4023@localhost.localdomain> (raw)
is there some reason there are so many calls of the form
memset(addr, 0, PAGE_SIZE)
rather than the apparently equivalent invocation of
clear_page(addr)
the majority of architectures appear to define the clear_page() macro
in their include/<arch>/page.h header file, but not entirely
identically, and in some cases that definition is conditional, as with
i386:
=============================================================
#ifdef CONFIG_X86_USE_3DNOW
...
#define clear_page(page) mmx_clear_page((void *)(page))
...
#else
...
#define clear_page(page) memset((void *)(page), 0, PAGE_SIZE)
...
#endif
============================================================
should it perhaps be part of the CodingStyle doc to use the
clear_page() macro rather than an explicit call to memset()? (and
should all architectures be required to define that macro?)
rday
next reply other threads:[~2006-12-29 6:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-29 6:16 Robert P. J. Day [this message]
2006-12-30 20:49 ` Denis Vlasenko
2006-12-30 22:08 ` Robert P. J. Day
2006-12-30 22:40 ` Denis Vlasenko
2007-01-03 6:23 ` dean gaudet
2006-12-30 22:45 ` Arjan van de Ven
2006-12-30 23:04 ` Robert P. J. Day
2006-12-31 18:39 ` Paul Mundt
2006-12-31 19:04 ` Robert P. J. Day
2007-01-01 1:59 ` Folkert van Heusden
2007-01-01 8:33 ` Robert P. J. Day
2007-01-01 10:14 ` Arjan van de Ven
2007-01-01 10:27 ` Robert P. J. Day
2007-01-01 19:05 ` Dave Jones
2007-01-01 8:42 ` Paul Mundt
2007-01-01 17:09 ` Randy Dunlap
2006-12-31 13:39 ` Folkert van Heusden
2006-12-31 13:45 ` Arjan van de Ven
2006-12-31 16:39 ` Robert P. J. Day
2006-12-31 17:43 ` Arjan van de Ven
2007-01-03 13:20 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0612290106550.4023@localhost.localdomain \
--to=rpjday@mindspring.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®