mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Muli Ben-Yehuda <muli@il.ibm.com>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>,
	trivial@kernel.org
Subject: Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.
Date: Mon, 1 Jan 2007 03:26:02 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0701010322320.2935@localhost.localdomain> (raw)
In-Reply-To: <66cc662565c489fa9e604073ced64889@kernel.crashing.org>

On Mon, 1 Jan 2007, Segher Boessenkool wrote:

> > > In this case, the second form
> > > should be used when the macro needs to return a value (and you can't
> > > use an inline function for whatever reason), whereas the first form
> > > should be used at all other times.
> >
> > that's a fair point, although it's certainly not the coding style
> > that's in play now.  for example,
> >
> >   #define setcc(cc) ({ \
> >     partial_status &= ~(SW_C0|SW_C1|SW_C2|SW_C3); \
> >     partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); })
>
> This _does_ return a value though, bad example.

sigh ... you're right.  here's a thought.  my original patch
submission simply added an explanation for allowing the ({ }) notation
for defining a multi-line macro, without getting into recommending an
actual coding style.  at a minimum, something like that should be
added to the style document.

if someone wants to extend that explanation recommending *when* each
of those two styles should be used, feel free.  but a simple
decription of alternatives should *at least* be added, no?

rday

  parent reply	other threads:[~2007-01-01  8:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-31 19:32 Robert P. J. Day
2006-12-31 19:45 ` Muli Ben-Yehuda
2006-12-31 19:49   ` Robert P. J. Day
2006-12-31 20:09     ` Muli Ben-Yehuda
2006-12-31 20:03       ` Randy Dunlap
2006-12-31 20:13       ` Robert P. J. Day
2007-01-01  2:40     ` Segher Boessenkool
2007-01-01  3:23       ` Randy Dunlap
2007-01-01  4:31         ` Segher Boessenkool
2007-01-01  4:30           ` Randy Dunlap
2007-01-01 15:37         ` Jan Engelhardt
2007-01-01 17:51           ` Segher Boessenkool
2007-01-01 19:11             ` Jan Engelhardt
2007-01-01  8:26       ` Robert P. J. Day [this message]
2007-01-01 14:20 ` Christoph Hellwig
2007-01-01 14:25   ` Robert P. J. Day
2007-01-01 16:14     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0701010322320.2935@localhost.localdomain \
    --to=rpjday@mindspring.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=muli@il.ibm.com \
    --cc=randy.dunlap@oracle.com \
    --cc=segher@kernel.crashing.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®