From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Replace __get_free_page() + memset(0) with get_zeroed_page() calls.
Date: Wed, 3 Jan 2007 09:55:48 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.0701030954470.26882@localhost.localdomain> (raw)
In-Reply-To: <459BBB36.1070907@gmail.com>
On Wed, 3 Jan 2007, Jiri Slaby wrote:
> Robert P. J. Day wrote:
> [...]
> > index fd82411..b3932e5 100644
> > --- a/include/asm-m68k/sun3_pgalloc.h
> > +++ b/include/asm-m68k/sun3_pgalloc.h
> > @@ -36,12 +36,11 @@ static inline void pte_free(struct page *page)
> > static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm,
> > unsigned long address)
> > {
> > - unsigned long page = __get_free_page(GFP_KERNEL|__GFP_REPEAT);
> > + unsigned long page = get_zeroed_page(GFP_KERNEL|__GFP_REPEAT);
> >
> > if (!page)
> > return NULL;
> >
> > - memset((void *)page, 0, PAGE_SIZE);
> > return (pte_t *) (page);
> > }
>
> perhaps simply
> return (pte_t *)get_zeroed_page(GFP_KERNEL|__GFP_REPEAT);
i thought about it, but figured i'd keep the change minimal and not
get into any "editorializing."
rday
prev parent reply other threads:[~2007-01-03 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-03 13:51 Robert P. J. Day
2007-01-03 14:19 ` Jiri Slaby
2007-01-03 14:55 ` Robert P. J. Day [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0701030954470.26882@localhost.localdomain \
--to=rpjday@mindspring.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®