From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Thomas Hisch <t.hisch@gmail.com>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Simplify some code to use the container_of() macro.
Date: Thu, 4 Jan 2007 03:48:20 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.0701040347360.5101@localhost.localdomain> (raw)
In-Reply-To: <20070104084224.GA3630@unknown-00-0d-60-79-ca-00.lan>
On Thu, 4 Jan 2007, Thomas Hisch wrote:
> On Sun, Dec 31, 2006 at 03:55:22PM -0500, Robert P. J. Day wrote:
> > @@ -1810,8 +1809,7 @@ lcs_get_frames_cb(struct lcs_channel *channel, struct lcs_buffer *buffer)
> > LCS_DBF_TEXT(4, trace, "-eiogpkt");
> > return;
> > }
> > - card = (struct lcs_card *)
> > - ((char *) channel - offsetof(struct lcs_card, read));
> > + card = container_of(channel, struct lcs_card, write);
> the last argument in container_of should be read instead of write.
gack, i really made a mess of that one, didn't i? sorry, i'll send
andrew a revised and healthy patch.
rday
next prev parent reply other threads:[~2007-01-04 8:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-31 20:55 Robert P. J. Day
2007-01-04 0:50 ` Andrew Morton
2007-01-04 7:40 ` Robert P. J. Day
2007-01-04 7:59 ` Robert P. J. Day
2007-01-04 8:42 ` Thomas Hisch
2007-01-04 8:48 ` Robert P. J. Day [this message]
2007-02-04 14:29 ` [PATCH] ipv4: remove a call to skb_queue_len() in inet_diag.c Thomas Hisch
2007-02-04 20:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0701040347360.5101@localhost.localdomain \
--to=rpjday@mindspring.com \
--cc=linux-kernel@vger.kernel.org \
--cc=t.hisch@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®