From: Hugh Dickins <hugh@veritas.com>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: clameter@sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slab: fix double-free in fallback_alloc
Date: Fri, 5 Jan 2007 20:46:42 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0701052037100.4444@blonde.wat.veritas.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0701051127180.17184@sbz-30.cs.Helsinki.FI>
On Fri, 5 Jan 2007, Pekka J Enberg wrote:
>
> Here's an alternative fix for the double-free bug you hit. I have only
> compile-tested this on NUMA so can you please confirm it fixes the problem
> for you? Thanks.
It looks nice, and I'm giving it a spin: though hardly worth waiting
a week or so to see if it hits the old double-free (took 3.5 days of
load when I saw it before), since you've fairly clearly rearranged
that out of existence - any bugs will be new ones all your own ;)
And I don't really have any NUMA anyway, just build that way ever
since testing some mempolicy change. So don't pay much attention to
my results, though of course I'll let you know if I see it go wrong.
The main thing is to make sure that your patch doesn't end up applied
to a tree with my patch in, since that would then be a (rare) leak.
Hugh
next prev parent reply other threads:[~2007-01-05 20:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-05 9:29 Pekka J Enberg
2007-01-05 17:47 ` Christoph Lameter
2007-01-05 20:46 ` Hugh Dickins [this message]
2007-01-06 13:10 ` Pekka J Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0701052037100.4444@blonde.wat.veritas.com \
--to=hugh@veritas.com \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®