From: Linus Torvalds <torvalds@linux-foundation.org>
To: Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>
Subject: Re: [PATCH] x86_64: fix put_user for 64-bit constant
Date: Thu, 25 Jan 2007 17:49:44 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0701251747530.25027@woody.linux-foundation.org> (raw)
In-Reply-To: <20070126011951.ECFD5180051@magilla.sf.frob.com>
On Thu, 25 Jan 2007, Roland McGrath wrote:
>
> On x86-64, a put_user call using a 64-bit pointer and a constant value that
> is > 0xffffffff will produce code that doesn't assemble. This patch fixes
> the asm construct to use the Z constraint for 32-bit constants.
Ahh. Will apply.
Just out of interest: did we have such code and it just happened to use a
register, or was this found because you wrote some new code that triggered
something that had just never been triggered before? Or is there a newer
gcc that is better at optimizations and finds a constant propagation where
it used to not find it?
Inquiring minds..
Linus
next prev parent reply other threads:[~2007-01-26 1:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-26 1:19 Roland McGrath
2007-01-26 1:49 ` Linus Torvalds [this message]
2007-01-26 5:41 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0701251747530.25027@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®