mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>, Pavel Machek <pavel@ucw.cz>
Subject: Re: mm snapshot broken-out-2007-01-26-00-36.tar.gz uploaded
Date: Fri, 26 Jan 2007 11:07:39 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0701261103530.5622@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <6bffcb0e0701261045q29cdb4ceq4577e5b0cec55d66@mail.gmail.com>

On Fri, 26 Jan 2007, Michal Piotrowski wrote:

> Please try patches from
> http://www.stardust.webpages.pl/files/tbf/euridica/mm-snapshot-2007-01-26/
> 
> http://www.stardust.webpages.pl/files/tbf/euridica/mm-snapshot-2007-01-26/bugs_and_patches.txt

Ahh. Okay that fixes most of the issues


ZVC writeback: Fix mm and other issues

This deals with swap prefetch and various things changed in mm.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

Index: linux-2.6.20-rc6/kernel/power/swsusp.c
===================================================================
--- linux-2.6.20-rc6.orig/kernel/power/swsusp.c	2007-01-26 10:32:05.000000000 -0800
+++ linux-2.6.20-rc6/kernel/power/swsusp.c	2007-01-26 10:51:56.000000000 -0800
@@ -230,9 +230,10 @@ int swsusp_shrink_memory(void)
 		for_each_zone (zone)
 			if (populated_zone(zone)) {
 				if (is_highmem(zone)) {
-					highmem_size -= zone->free_pages;
+					highmem_size -=
+					zone_page_state(zone, NR_FREE_PAGES);
 				} else {
-					tmp -= zone->free_pages;
+					tmp -= zone_page_state(zone, NR_FREE_PAGES);
 					tmp += zone->lowmem_reserve[ZONE_NORMAL];
 					tmp += snapshot_additional_pages(zone);
 				}
Index: linux-2.6.20-rc6/mm/page_alloc.c
===================================================================
--- linux-2.6.20-rc6.orig/mm/page_alloc.c	2007-01-26 10:32:19.000000000 -0800
+++ linux-2.6.20-rc6/mm/page_alloc.c	2007-01-26 10:48:04.000000000 -0800
@@ -1581,12 +1581,12 @@ unsigned int nr_free_pagecache_pages(voi
 unsigned long nr_free_inactive_pages_node(int nid)
 {
 	enum zone_type i;
-	unsigned long sum = 0;
+	unsigned long sum = node_page_state(nid, NR_FREE_PAGES)
+				+ node_page_state(nid, NR_INACTIVE);
 	struct zone *zones = NODE_DATA(nid)->node_zones;
 
 	for (i = 0; i < MAX_NR_ZONES; i++)
-		sum += zones[i].nr_inactive +
-			zones[i].free_pages - zones[i].pages_low;
+		sum -= zones[i].pages_low;
 
 	return sum;
 }
@@ -1634,7 +1634,8 @@ void si_meminfo_node(struct sysinfo *val
 	val->freeram = node_page_state(nid, NR_FREE_PAGES);
 #ifdef CONFIG_HIGHMEM
 	val->totalhigh = pgdat->node_zones[ZONE_HIGHMEM].present_pages;
-	val->freehigh = pgdat->node_zones[ZONE_HIGHMEM].free_pages;
+	val->freehigh = zone_page_state(&pgdat->node_zones[ZONE_HIGHMEM],
+			NR_FREE_PAGES);
 #else
 	val->totalhigh = 0;
 	val->freehigh = 0;
Index: linux-2.6.20-rc6/mm/swap_prefetch.c
===================================================================
--- linux-2.6.20-rc6.orig/mm/swap_prefetch.c	2007-01-26 10:51:53.000000000 -0800
+++ linux-2.6.20-rc6/mm/swap_prefetch.c	2007-01-26 10:51:56.000000000 -0800
@@ -281,7 +281,7 @@ static void examine_free_limits(void)
 		ns->lowfree[idx] = z->pages_high * 3;
 		ns->highfree[idx] = ns->lowfree[idx] + z->pages_high;
 
-		if (z->free_pages > ns->highfree[idx]) {
+		if (zone_page_state(z, NR_FREE_PAGES) > ns->highfree[idx]) {
 			/*
 			 * We've gotten above the high watermark of free pages
 			 * so we can start prefetching till we get to the low
@@ -338,7 +338,7 @@ static int prefetch_suitable(void)
 		ns = &sp_stat.node[node];
 		idx = zone_idx(z);
 
-		free = z->free_pages;
+		free = zone_page_state(z, NR_FREE_PAGES);
 		if (free < *ns->pointfree[idx]) {
 			/*
 			 * Free pages have dropped below the low watermark so
Index: linux-2.6.20-rc6/include/linux/mm_inline.h
===================================================================
--- linux-2.6.20-rc6.orig/include/linux/mm_inline.h	2007-01-26 10:58:53.000000000 -0800
+++ linux-2.6.20-rc6/include/linux/mm_inline.h	2007-01-26 10:58:59.000000000 -0800
@@ -16,7 +16,7 @@ static inline void
 add_page_to_inactive_list_tail(struct zone *zone, struct page *page)
 {
 	list_add_tail(&page->lru, &zone->inactive_list);
-	zone->nr_inactive++;
+	__inc_zone_state(zone, NR_INACTIVE);
 }
 
 static inline void

  reply	other threads:[~2007-01-26 19:07 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200701260837.l0Q8blBr011622@shell0.pdx.osdl.net>
2007-01-26 15:04 ` Michal Piotrowski
2007-01-26 15:33   ` Serge E. Hallyn
2007-01-26 15:38     ` Serge E. Hallyn
2007-01-26 16:06       ` Michal Piotrowski
2007-01-26 16:37 ` Michal Piotrowski
2007-01-26 16:46 ` Michal Piotrowski
2007-01-26 16:57 ` Michal Piotrowski
2007-01-26 17:29 ` Michal Piotrowski
2007-01-26 18:14   ` Serge E. Hallyn
2007-01-26 18:22     ` Michal Piotrowski
2007-01-26 18:58       ` Serge E. Hallyn
2007-01-26 17:48 ` Michal Piotrowski
2007-01-26 18:04 ` Michal Piotrowski
     [not found]   ` <6bffcb0e0701261008u2fd5a7d9va16d7fd9f250e14b@mail.gmail.com>
2007-01-26 18:38     ` Christoph Lameter
2007-01-26 18:43       ` Pavel Machek
2007-01-26 18:45       ` Michal Piotrowski
2007-01-26 19:07         ` Christoph Lameter [this message]
2007-01-26 19:20           ` Michal Piotrowski
2007-01-26 19:45 ` Michal Piotrowski
     [not found]   ` <6bffcb0e0701261523j3a84a357lad93260b5865c99d@mail.gmail.com>
2007-01-27  0:33     ` Andrew Morton
2007-01-27  0:41       ` Michal Piotrowski
2007-01-27  0:29 ` Michal Piotrowski
2007-01-27 15:05 ` Michal Piotrowski
2007-01-27 20:38   ` Herbert Xu
2007-01-27 16:03 ` Michal Piotrowski
2007-01-30  1:05   ` Tejun Heo
2007-01-27 16:14 ` Michal Piotrowski
2007-01-27 17:20 ` Michal Piotrowski
     [not found] ` <6bffcb0e0701270837i1ec40560l6e61e8876177e9da@mail.gmail.com>
2007-01-27 21:29   ` Tilman Schmidt
2007-01-27 21:41     ` Andrew Morton
2007-01-27 22:12       ` Michal Piotrowski
2007-01-27 23:25       ` Tilman Schmidt
2007-01-27 23:27         ` Michal Piotrowski
2007-01-28  2:41       ` Valdis.Kletnieks
2007-01-28  3:37         ` Michal Piotrowski
2007-01-29  2:49         ` Valdis.Kletnieks
2007-01-29  6:08           ` Eric W. Biederman
2007-01-29  6:45             ` Valdis.Kletnieks
2007-01-29  8:24               ` Eric W. Biederman
2007-01-29  2:58         ` Valdis.Kletnieks
2007-01-29  5:14           ` Randy Dunlap
2007-01-29  5:46           ` Valdis.Kletnieks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0701261103530.5622@schroedinger.engr.sgi.com \
    --to=clameter@sgi.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®