From: Christoph Lameter <clameter@sgi.com>
To: akpm@osdl.org
Cc: Oleg Nesterov <oleg@tv-sign.ru>, linux-kernel@vger.kernel.org
Subject: Re: [SLAB] Shutdown cache_reaper when cpu goes down
Date: Thu, 1 Feb 2007 15:19:33 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0702011517110.9210@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0702011111560.8307@schroedinger.engr.sgi.com>
The comments do not explain correctly what is going on. Sorry Oleg but it
seems that the protection of the assignment to reap_work is different that
what we initially thought.
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Index: current/mm/slab.c
===================================================================
--- current.orig/mm/slab.c 2007-02-01 15:07:09.000000000 -0800
+++ current/mm/slab.c 2007-02-01 15:09:21.000000000 -0800
@@ -1274,10 +1274,12 @@ static int __cpuinit cpuup_callback(stru
case CPU_DOWN_PREPARE:
/*
* Shutdown cache reaper. Note that the cache_chain_mutex is
- * held so that cache_reap() cannot modify reap_work
- * concurrently.
+ * held so that if cache_reap() is invoked it cannot do
+ * anything expensive but will only modify reap_work
+ * and reschedule the timer.
*/
cancel_rearming_delayed_work(&per_cpu(reap_work, cpu));
+ /* Now the cache_reaper is guaranteed to be not running. */
per_cpu(reap_work, cpu).work.func = NULL;
break;
case CPU_DOWN_FAILED:
next prev parent reply other threads:[~2007-02-01 23:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-01 19:13 Christoph Lameter
2007-02-01 23:19 ` Christoph Lameter [this message]
2007-02-02 0:55 ` Andrew Morton
2007-02-02 2:14 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0702011517110.9210@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®