From: James Morris <jmorris@namei.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@muc.de>, Andrew Morton <akpm@linux-foundation.org>,
virtualization <virtualization@lists.osdl.org>
Subject: Re: [PATCH 4 of 7] lguest: Config and headers
Date: Fri, 9 Feb 2007 13:15:28 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.0702091304090.9927@d.namei> (raw)
In-Reply-To: <1171033741.2718.172.camel@localhost.localdomain>
On Sat, 10 Feb 2007, Rusty Russell wrote:
> +/* 64k ought to be enough for anybody! */
> +#define HYPERVISOR_MAP_ORDER 16
> +#define HYPERVISOR_PAGES ((1 << HYPERVISOR_MAP_ORDER)/PAGE_SIZE)
I think it'd be better to go back to defining HYPERVISOR_SIZE then derive
the map order from that via get_order(), as it should be 4 instead of 16;
and this code is now both implying PAGE_SIZE while also using it for
calculations.
- James
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2007-02-09 18:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-09 14:59 [PATCH 0 of 7] lguest host code Rusty Russell
2007-02-09 15:03 ` [PATCH 1 of 7] lguest: Move mce_disabled to asm/mce.h so lguest can use it Rusty Russell
2007-02-09 15:03 ` [PATCH 2 of 7] lguest: Rename cpu_gdt_descr and remove extern declaration from smpboot.c Rusty Russell
2007-02-09 15:04 ` [PATCH 3 of 7] lguest: Remove extern declaration from mm/discontig.c, put in header Rusty Russell
2007-02-09 15:09 ` [PATCH 4 of 7] lguest: Config and headers Rusty Russell
2007-02-09 15:14 ` [PATCH 5 of 7] lguest: the host code (lg.ko) Rusty Russell
2007-02-09 15:17 ` [PATCH 6 of 7] lguest: Guest code Rusty Russell
2007-02-09 15:21 ` [PATCH 7 of 7] lguest: Makefile Rusty Russell
2007-02-09 18:15 ` James Morris [this message]
2007-02-09 23:41 ` [PATCH 4 of 7] lguest: Config and headers Rusty Russell
2007-02-10 3:45 ` James Morris
2007-02-10 9:33 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0702091304090.9927@d.namei \
--to=jmorris@namei.org \
--cc=ak@muc.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®