From: Davide Libenzi <davidel@xmailserver.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Arjan van de Ven <arjan@infradead.org>,
Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@zip.com.au>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Ulrich Drepper <drepper@redhat.com>,
Zach Brown <zach.brown@oracle.com>,
Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
"David S. Miller" <davem@davemloft.net>,
Suparna Bhattacharya <suparna@in.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [patch 08/14] syslets: x86, add create_async_thread() method
Date: Thu, 15 Feb 2007 11:14:58 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0702151111250.11064@alien.or.mcafeemobile.com> (raw)
In-Reply-To: <20070215165239.GI4285@elte.hu>
On Thu, 15 Feb 2007, Ingo Molnar wrote:
> +ENTRY(async_thread_helper)
> + CFI_STARTPROC
> + /*
> + * Allocate space on the stack for pt-regs.
> + * sizeof(struct pt_regs) == 64, and we've got 8 bytes on the
> + * kernel stack already:
> + */
> + subl $64-8, %esp
> + CFI_ADJUST_CFA_OFFSET 64
Maybe a comment here would help in explaining why we do need space for the
extra pt_regs (on top of the one already allocated in do_fork()) ;)
It's not immediately clear that ret_from_fork and syscall_exit will issue
two nested RESTORE_REGS.
- Davide
next prev parent reply other threads:[~2007-02-15 19:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-15 16:52 Ingo Molnar
2007-02-15 19:14 ` Davide Libenzi [this message]
2007-02-17 11:44 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0702151111250.11064@alien.or.mcafeemobile.com \
--to=davidel@xmailserver.org \
--cc=akpm@zip.com.au \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=davem@davemloft.net \
--cc=drepper@redhat.com \
--cc=hch@infradead.org \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suparna@in.ibm.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®