From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2
Date: Wed, 28 Feb 2007 09:34:12 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0702280931480.12485@woody.linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0702281814380.4255@jikos.suse.cz>
On Wed, 28 Feb 2007, Jiri Kosina wrote:
>
> You're right that usbhid.h is not a best place for it.
"Not the best place for it" is the understatement of the year.
It's totally idiotic.
> This IMHO just needs cleanup. Will you accept creating a separate header
> file solely for purposes of this blacklist and related defines?
*NO*.
Dammit, we don't put static initializers in header files. We don't
duplicate the data in every single thing that includes a header file. If
you want to duplicate the data, you export it as a real data structure,
and you *still* put the data structure in a .c file.
> Otherwise I will just drop this cleanup, but I still think that the
> current situation is horrible.
WHAT CLEANUP? The thing is the anti-thesis of a "cleanup". There is no
excuse for putting a large array in a header file and including it
millions of times. Or even just twice. The point of a header file is to
*declare* things, not to have big data structures in.
Linus
next prev parent reply other threads:[~2007-02-28 17:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-28 10:19 Jiri Kosina
2007-02-28 17:09 ` Linus Torvalds
2007-02-28 17:25 ` Jiri Kosina
2007-02-28 17:34 ` Linus Torvalds [this message]
2007-02-28 17:41 ` Jiri Kosina
2007-02-28 18:20 ` Linus Torvalds
2007-02-28 18:28 ` Linus Torvalds
2007-02-28 18:33 ` Randy Dunlap
2007-02-28 18:29 ` Jiri Kosina
2007-02-28 18:39 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0702280931480.12485@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®