From: Davide Libenzi <davidel@xmailserver.org>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [patch - v3] epoll ready set loops diet ...
Date: Wed, 28 Feb 2007 11:23:37 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0702281115090.6806@alien.or.mcafeemobile.com> (raw)
In-Reply-To: <200702282009.29527.dada1@cosmosbay.com>
On Wed, 28 Feb 2007, Eric Dumazet wrote:
> On Wednesday 28 February 2007 19:37, Davide Libenzi wrote:
>
> > + list_del(&epi->rdllink);
> > + if (!(epi->event.events & EPOLLET) && (revents & epi->event.events))
> > + list_add_tail(&epi->rdllink, &injlist);
> > + else {
>
> Is the ( ... & epi->event.events) really necessary ? (It seems already done)
Yes, look here:
if (epi->event.events & EPOLLONESHOT)
epi->event.events &= EP_PRIVATE_BITS;
Oneshot events should not be requeued.
> I was wrong about the size of epitem : it is now 68 bytes instead of 72.
> At least we now use/dirty one cache line instead of two per epitem.
>
> Do you have another brilliant idea to shrink 4 more bytes ? :)
I don't think we can cleanly shove more stuff out of it.
- Davide
next prev parent reply other threads:[~2007-02-28 19:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-28 18:37 Davide Libenzi
2007-02-28 19:09 ` Eric Dumazet
2007-02-28 19:23 ` Davide Libenzi [this message]
2007-03-01 21:30 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0702281115090.6806@alien.or.mcafeemobile.com \
--to=davidel@xmailserver.org \
--cc=akpm@linux-foundation.org \
--cc=dada1@cosmosbay.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®