From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752142AbXCJGyR (ORCPT ); Sat, 10 Mar 2007 01:54:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751608AbXCJGyR (ORCPT ); Sat, 10 Mar 2007 01:54:17 -0500 Received: from x35.xmailserver.org ([64.71.152.41]:44674 "EHLO x35.xmailserver.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751209AbXCJGyQ (ORCPT ); Sat, 10 Mar 2007 01:54:16 -0500 X-AuthUser: davidel@xmailserver.org Date: Fri, 9 Mar 2007 22:53:55 -0800 (PST) From: Davide Libenzi X-X-Sender: davide@alien.or.mcafeemobile.com To: Nicholas Miell cc: Linux Kernel Mailing List , Andrew Morton , Linus Torvalds Subject: Re: [patch 6/9] signalfd/timerfd v1 - timerfd core ... In-Reply-To: <1173509019.3108.4.camel@entropy> Message-ID: References: <1173508384.3108.1.camel@entropy> <1173509019.3108.4.camel@entropy> X-GPG-FINGRPRINT: CFAE 5BEE FD36 F65E E640 56FE 0974 BF23 270F 474E X-GPG-PUBLIC_KEY: http://www.xmailserver.org/davidel.asc MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Mar 2007, Nicholas Miell wrote: > On Fri, 2007-03-09 at 22:38 -0800, Davide Libenzi wrote: > > On Fri, 9 Mar 2007, Nicholas Miell wrote: > > > > > Why did you ignore the existing POSIX timer API? > > > > The existing POSIX API is a standard and a very good one. Too bad it does > > not deliver to files. The timerfd code is, as you can probably read from > > the code, a really thin wrapper around the existing hrtimer.c Linux code. > > So extend the existing POSIX timer API to deliver expiry events via a > fd. It'll be out of standard as timerfd is, w/out code savings. Look at the code and tell me what could be saved. Prolly the ten lines of the timer callback. Lines that you'll have to drop inside the current posix timer layer. Better leave standards alone, especially like in this case, when the savings are not there. - Davide