From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751667AbXCLTAm (ORCPT ); Mon, 12 Mar 2007 15:00:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752146AbXCLTAm (ORCPT ); Mon, 12 Mar 2007 15:00:42 -0400 Received: from x35.xmailserver.org ([64.71.152.41]:33740 "EHLO x35.xmailserver.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751667AbXCLTAl (ORCPT ); Mon, 12 Mar 2007 15:00:41 -0400 X-AuthUser: davidel@xmailserver.org Date: Mon, 12 Mar 2007 12:00:34 -0700 (PDT) From: Davide Libenzi X-X-Sender: davide@alien.or.mcafeemobile.com To: Thomas Gleixner cc: Linux Kernel Mailing List , Andrew Morton , Linus Torvalds Subject: Re: [patch 6/9] signalfd/timerfd v3 - timerfd core ... In-Reply-To: Message-ID: References: <1173694763.13341.81.camel@localhost.localdomain> X-GPG-FINGRPRINT: CFAE 5BEE FD36 F65E E640 56FE 0974 BF23 270F 474E X-GPG-PUBLIC_KEY: http://www.xmailserver.org/davidel.asc MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Mar 2007, Davide Libenzi wrote: > On Mon, 12 Mar 2007, Thomas Gleixner wrote: > > > Davide, > > > > On Sun, 2007-03-11 at 16:04 -0700, Davide Libenzi wrote: > > > +static int timerfd_setup(struct timerfd_ctx *ctx, int clockid, int tmrtype, > > > + const struct itimerspec *ktmr) > > > +{ > > > + enum hrtimer_mode htmode; > > > + ktime_t texp, tintv; > > > + > > > + if (clockid != CLOCK_MONOTONIC && > > > + clockid != CLOCK_REALTIME) > > > + return -EINVAL; Maybe a function in hrtimer.c/h like hrtimer_valid_clockid(clockid_t id) to avoid bolting in clockid_t values in timerfd.c? - Davide