From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933307AbXCMVla (ORCPT ); Tue, 13 Mar 2007 17:41:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933365AbXCMVl3 (ORCPT ); Tue, 13 Mar 2007 17:41:29 -0400 Received: from smtp.osdl.org ([65.172.181.24]:37021 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933307AbXCMVl2 (ORCPT ); Tue, 13 Mar 2007 17:41:28 -0400 Date: Tue, 13 Mar 2007 14:32:07 -0700 (PDT) From: Linus Torvalds To: Steven Rostedt cc: linux-kernel@vger.kernel.org, Andrew Morton , Ingo Molnar , Chris Wright , Rusty Russell , Andi Kleen , Glauber de Oliveira Costa , Jeremy Fitzhardinge Subject: Re: [RFC/PATCH 06/59] mv kernel/acpi/processor.c In-Reply-To: <1173820977.28042.13.camel@localhost.localdomain> Message-ID: References: <20070313204458.531339803@goodmis.org> <1173820977.28042.13.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Mar 2007, Steven Rostedt wrote: > > Move kernel/acpi/processor.c to the common hold. Please use git diff -M for things like this. In fact, even if you weren't a git user, I'd ask you to *become* one just because I think that it's a *lot* more productive if people actually see renames as renames, and will see what - if anything - changed when renaming. The "-M" flag isn't the default, simply because it generates patches that cannot be applied with regular "patch", but for something like this, I think it's practically imperative. The old kind of "remove file" + "add file" patch just isn't acceptable when there are very viable alternaties. You don't even have to use a git repository to use a git rename patch - you just need to use "git apply" to apply it. Linus