From: Davide Libenzi <davidel@xmailserver.org>
To: Frank Seidel <frank@kernalert.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch 5/9] signalfd/timerfd v3 - signalfd compat code ...
Date: Wed, 14 Mar 2007 08:29:32 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0703140827270.1021@alien.or.mcafeemobile.com> (raw)
In-Reply-To: <200703141619.28505.frank@kernalert.de>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 959 bytes --]
On Wed, 14 Mar 2007, Frank Seidel wrote:
> On Monday 12 March 2007 20:19:27 Davide Libenzi wrote:
> Hi,
> i'm not (at least until yet) really that familiar with the kernel, but
> currently trying to get into it also via reading of code and patches
> here. So please don't take my comments in this (and posibly following)
> mails to serious. ;-)
>
> > +asmlinkage long compat_sys_signalfd(int ufd,
> > + const compat_sigset_t __user
> *sigmask,
> > + compat_size_t sigsetsize)
> > +{
> > + compat_sigset_t ss32;
> > + sigset_t tmp;
> > + sigset_t __user *ksigmask;
> > +
> Would it be good to put this in a
>
> if (sigmask) {
>
> like its e.g. done in compat_sys_epoll_pwait or would this be
> totally useless here?
On the contrary or epoll_pwait (same family of ppoll/pselect), the sigmask
is needed here, by the API definition.
- Davide
prev parent reply other threads:[~2007-03-14 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-11 23:04 Davide Libenzi
2007-03-14 15:19 ` Frank Seidel
2007-03-14 15:29 ` Davide Libenzi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0703140827270.1021@alien.or.mcafeemobile.com \
--to=davidel@xmailserver.org \
--cc=frank@kernalert.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®