From: Davide Libenzi <davidel@xmailserver.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Benjamin LaHaise <bcrl@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Suparna Bhattacharya <suparna@in.ibm.com>,
Zach Brown <zach.brown@oracle.com>
Subject: Re: [patch 13/13] signalfd/timerfd/asyncfd v5 - KAIO asyncfd support (example/maybe-broken) ...
Date: Wed, 14 Mar 2007 17:15:13 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0703141713380.4982@alien.or.mcafeemobile.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0703141711451.9690@woody.linux-foundation.org>
On Wed, 14 Mar 2007, Linus Torvalds wrote:
> On Wed, 14 Mar 2007, Davide Libenzi wrote:
> > >
> > > That won't work. aio_complete() is supposed to be irq safe.
> >
> > Can you point me to a kernel path that ends up calling aio_complete() in a
> > do-not-sleep mode?
>
> All of them.
>
> It's called from dio_bio_end_aio(), which is the bi_end_io function for an
> AIO action. Which in turn is called at IO completion time.
>
> Which is basically _always_ interrupt context.
>
> So you cannot sleep. It's not about holding spinlocks (which it might well
> do as well). It's about a much more fundamental issue: you can only sleep
> in process context, not from interrupts.
Ack! Gotcha. Sigh! :)
- Davide
prev parent reply other threads:[~2007-03-15 0:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 22:19 Davide Libenzi
2007-03-14 23:19 ` Benjamin LaHaise
2007-03-14 23:24 ` Davide Libenzi
2007-03-14 23:42 ` Benjamin LaHaise
2007-03-14 23:41 ` Davide Libenzi
2007-03-14 23:49 ` Davide Libenzi
2007-03-15 0:02 ` Benjamin LaHaise
2007-03-15 0:10 ` Davide Libenzi
2007-03-15 0:27 ` Davide Libenzi
2007-03-15 0:15 ` Linus Torvalds
2007-03-15 0:15 ` Davide Libenzi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0703141713380.4982@alien.or.mcafeemobile.com \
--to=davidel@xmailserver.org \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suparna@in.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®