From: Christoph Lameter <clameter@sgi.com>
To: Paul Mackerras <paulus@samba.org>
Cc: akpm@linux-foundation.org, linux-mm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [QUICKLIST 1/5] Quicklists for page table pages V3
Date: Tue, 20 Mar 2007 12:43:27 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0703201241560.8729@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <17919.20743.384741.398444@cargo.ozlabs.ibm.com>
On Tue, 20 Mar 2007, Paul Mackerras wrote:
> Christoph Lameter writes:
>
> > +static inline void *quicklist_alloc(int nr, gfp_t flags, void (*ctor)(void *))
> > +{
>
> ...
>
> > + p = (void *)__get_free_page(flags | __GFP_ZERO);
>
> This will cause problems on 64-bit powerpc, at least with 4k pages,
> since the pmd and pgd levels only use 1/4 of a page.
quicklists are only useful for page sized allocations. If you have smaller
sizes then by all means continue the use of slab. You do not have a page
struct for each pmd, pgd to do bad things with (like i386) so everything
is just fine.
prev parent reply other threads:[~2007-03-20 19:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 23:37 Christoph Lameter
2007-03-19 23:37 ` [QUICKLIST 2/5] Quicklist support for IA64 Christoph Lameter
2007-03-19 23:37 ` [QUICKLIST 3/5] Quicklist support for i386 Christoph Lameter
2007-03-19 23:37 ` [QUICKLIST 4/5] Quicklist support for x86_64 Christoph Lameter
2007-03-19 23:37 ` [QUICKLIST 5/5] Quicklist support for sparc64 Christoph Lameter
2007-03-19 23:53 ` [QUICKLIST 1/5] Quicklists for page table pages V3 Andrew Morton
2007-03-19 23:57 ` Christoph Lameter
2007-03-20 0:07 ` Andrew Morton
2007-03-20 0:44 ` Christoph Lameter
2007-03-20 0:55 ` Andrew Morton
2007-03-20 1:03 ` Christoph Lameter
2007-03-20 1:32 ` Andrew Morton
2007-03-20 19:41 ` Christoph Lameter
2007-03-19 23:58 ` David Miller
2007-03-20 0:21 ` Andrew Morton
2007-03-20 1:06 ` Christoph Lameter
2007-03-20 3:12 ` Paul Mackerras
2007-03-20 19:43 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0703201241560.8729@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®