From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933688AbXDARYH (ORCPT ); Sun, 1 Apr 2007 13:24:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933691AbXDARYG (ORCPT ); Sun, 1 Apr 2007 13:24:06 -0400 Received: from smtp.osdl.org ([65.172.181.24]:46216 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933688AbXDARYF (ORCPT ); Sun, 1 Apr 2007 13:24:05 -0400 Date: Sun, 1 Apr 2007 10:23:00 -0700 (PDT) From: Linus Torvalds To: Davide Libenzi cc: Avi Kivity , Linux Kernel Mailing List , Andrew Morton , Ingo Molnar , Suparna Bhattacharya , Zach Brown , Benjamin LaHaise Subject: Re: [patch 13/13] signal/timer/event fds v9 - KAIO eventfd support example ... In-Reply-To: Message-ID: References: <460FCA90.4000003@argo.co.il> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 1 Apr 2007, Davide Libenzi wrote: > > > [also, minor nit: sys_eventfd() can legitimately return 0, but you're banning > > its use in aio. userspace could easily dup() and close(), but...] > > Noone said that binary compatibility comes free ;) > I'm truly open to other ways of integration, but I thought that binary > compatibility is the key here. I would suggest taking "aio_reserved3" and turning it into __u32 aio_flags; __u32 aio_resfd; if so. And then some bit in the "flags" field has to be set (say, "IOCB_FLAG_RESFB") to enable this codepath, instead of expecting that aio_resfd == 0 is special. It's generally always a good thing to have a "flags" field anyway, exactly because it allows for future expansion. Linus