From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933869AbXDASuG (ORCPT ); Sun, 1 Apr 2007 14:50:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933887AbXDASuG (ORCPT ); Sun, 1 Apr 2007 14:50:06 -0400 Received: from x35.xmailserver.org ([64.71.152.41]:48894 "EHLO x35.xmailserver.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933869AbXDASuE (ORCPT ); Sun, 1 Apr 2007 14:50:04 -0400 X-AuthUser: davidel@xmailserver.org Date: Sun, 1 Apr 2007 11:49:57 -0700 (PDT) From: Davide Libenzi X-X-Sender: davide@alien.or.mcafeemobile.com To: Avi Kivity cc: Linux Kernel Mailing List , Andrew Morton , Linus Torvalds , Ingo Molnar , Suparna Bhattacharya , Zach Brown , Benjamin LaHaise Subject: Re: [patch 13/13] signal/timer/event fds v9 - KAIO eventfd support example ... In-Reply-To: <460FFD0F.7080107@argo.co.il> Message-ID: References: <460FCA90.4000003@argo.co.il> <460FFD0F.7080107@argo.co.il> X-GPG-FINGRPRINT: CFAE 5BEE FD36 F65E E640 56FE 0974 BF23 270F 474E X-GPG-PUBLIC_KEY: http://www.xmailserver.org/davidel.asc MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 1 Apr 2007, Avi Kivity wrote: > Davide Libenzi wrote: > > On Sun, 1 Apr 2007, Avi Kivity wrote: > > > > > > > What is the motivation for adding aio_resfd to an individual iocb instead > > > of > > > the entire io context? It seems redundant, as you can already create > > > multiple > > > io contexts to wait on. > > > > > > > To add it to the context, you need to either change the context create API > > (I think no-go here), or add a new syscall just to handle that. > > Doing it in the iocb gives finer grained setup, but can be more work for the > > user that wants to use it for all the iocbs. > > > > I think it's a bit too fine grained, and a new system call (io_bindfd()?) > would be easier to use. In addition, you would move the eventfd_fget() out of > the submission path. IMO the cost of the eventfd_fget() (have you seen it?) is not worth adding a new syscall. Actually, the flags field that Linus suggested may be given an extra meaning of "bind to ctx", that'd solve the problem w/out new syscalls. - Davide