mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Hugh Dickins <hugh@veritas.com>, Nick Piggin <npiggin@suse.de>,
	dgc@sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Make page->private usable in compound pages V1
Date: Fri, 6 Apr 2007 10:01:38 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0704060958430.25652@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20070405164300.a5d24329.akpm@linux-foundation.org>

On Thu, 5 Apr 2007, Andrew Morton wrote:

> > We add PageTail as an alias of PageReclaim. Compound pages cannot
> > currently be reclaimed. Because of the alias one needs to check
> > PageCompound first.
> 
> So slub is using compound pages so that it can locate the head page in
> higher-order pages, whereas slab uses per-object (or per-order-0-page?)
> metadata for that?

Both SLAB and SLUB use compound pages.

> 
> I see four instances of
> 
> +	page = virt_to_page(p);
> +
> +	if (unlikely(PageCompound(page)))
> +		page = page->first_page;
> 
> A new virt_to_head_page() is needed.

Ok.
 
 > Sigh.  We're seeing rather a lot of churn to accommodate slub.  Do we
> actually have any justification for all this?  If we end up deciding to
> merge slub and to deprecate then remove slab, what would our reasons have
> been?

This is not SLUB specific. SLAB does the same. SLAB does special casing 
for page size slabs and does not allow slab debugging because it would 
use page->private if debugging would be enabled. Which would get into 
trouble on i386.

If you want less SLUB churn on other fronts then I can add the special 
casing for PAGE_SIZE slabs back into SLUB. Then we keep all the 
inconsistencies in SLAB use in the code.

I'd rather clean up the stuff and then also remove the special casing from 
SLAB.

 

  reply	other threads:[~2007-04-06 17:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-05 22:36 Christoph Lameter
2007-04-05 22:36 ` [PATCH 2/2] Optimize compound_head() by avoiding a shared page flag Christoph Lameter
2007-04-07  5:23   ` Andrew Morton
2007-04-07 22:16     ` Christoph Lameter
2007-04-07 22:51       ` Andrew Morton
2007-04-08  0:21         ` Christoph Lameter
2007-04-08  1:25           ` Andrew Morton
2007-04-08  1:32             ` Christoph Lameter
2007-04-08  1:48               ` Andrew Morton
2007-04-09 17:22                 ` Christoph Lameter
2007-04-09 18:09                 ` Christoph Lameter
2007-04-09 18:45                   ` Andrew Morton
2007-04-09 18:49                     ` Christoph Lameter
2007-04-09 22:05                     ` Christoph Lameter
2007-04-05 23:43 ` [PATCH 1/2] Make page->private usable in compound pages V1 Andrew Morton
2007-04-06 17:01   ` Christoph Lameter [this message]
2007-04-06 20:04     ` Andrew Morton
2007-04-06 20:28       ` Christoph Lameter
2007-04-06 19:46   ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0704060958430.25652@schroedinger.engr.sgi.com \
    --to=clameter@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=dgc@sgi.com \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®