From: Christoph Lameter <clameter@sgi.com>
To: Neil Brown <neilb@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: SLUB: kmem_cache_destroy doesn't
Date: Thu, 12 Apr 2007 09:38:15 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0704120937350.26701@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <17949.57189.565653.289035@notabene.brown>
On Thu, 12 Apr 2007, Neil Brown wrote:
> And
>
> # cat /sys/slab/raid5-md1/aliases
> -1
>
> is a bit suspicious.
Yuck!
> void kmem_cache_destroy(struct kmem_cache *s)
> {
> down_write(&slub_lock);
> if (s->refcount)
> s->refcount--;
> else {
> list_del(&s->list);
> WARN_ON(kmem_cache_close(s));
> sysfs_slab_remove(s);
> kfree(s);
> }
> up_write(&slub_lock);
> }
>
> looks a bit odd.
> I would have thought the test should be:
>
> if (s->refcount > 1)
Correct. Does the change fix it?
prev parent reply other threads:[~2007-04-12 16:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-12 7:27 Neil Brown
2007-04-12 16:38 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0704120937350.26701@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®