From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161182AbXDNMXz (ORCPT ); Sat, 14 Apr 2007 08:23:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161172AbXDNMXy (ORCPT ); Sat, 14 Apr 2007 08:23:54 -0400 Received: from nic.NetDirect.CA ([216.16.235.2]:49465 "EHLO rubicon.netdirect.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161182AbXDNMXy (ORCPT ); Sat, 14 Apr 2007 08:23:54 -0400 X-Originating-Ip: 24.6.145.253 Date: Sat, 14 Apr 2007 08:22:26 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Stephen Rothwell cc: Linux Kernel Mailing List Subject: {Spam?} Re: [PATCH][RFC] Kill off legacy power management stuff. In-Reply-To: <20070413183054.08ca0dff.sfr@canb.auug.org.au> Message-ID: References: <20070413180942.b7cf0665.sfr@canb.auug.org.au> <20070413183054.08ca0dff.sfr@canb.auug.org.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Net-Direct-Inc-MailScanner-Information: Please contact the ISP for more information X-Net-Direct-Inc-MailScanner: Found to be clean X-Net-Direct-Inc-MailScanner-SpamCheck: spam, SORBS-DUL, SpamAssassin (not cached, score=-12.808, required 5, ALL_TRUSTED -1.80, BAYES_00 -15.00, RCVD_IN_NJABL_DUL 1.95, RCVD_IN_SORBS_DUL 2.05) X-Net-Direct-Inc-MailScanner-From: rpjday@mindspring.com Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Apr 2007, Stephen Rothwell wrote: > On Fri, 13 Apr 2007 04:20:10 -0400 (EDT) "Robert P. J. Day" wrote: > > > > On Fri, 13 Apr 2007, Stephen Rothwell wrote: > > > > > > One thing that comes to mind is that you will need some way to > > > make sure that only one of ACPI and APM get initialized ... > > > > i don't see how that has anything to do with removing legacy PM > > support. you can select both ACPI and APM *now*. if that's a bad > > thing, then fixing it is a completely independent issue. > > Except your patch removes this hunk: > > @@ -2264,14 +2248,6 @@ static int __init apm_init(void) > apm_info.disabled = 1; > return -ENODEV; > } > - if (PM_IS_ACTIVE()) { > - printk(KERN_NOTICE "apm: overridden by ACPI.\n"); > - apm_info.disabled = 1; > - return -ENODEV; > - } > -#ifdef CONFIG_PM_LEGACY > - pm_active = 1; > -#endif > > in apm.c and a similar piece of the ACPI initialisation that prevented > one initialising if the other had already initialised. you have a point, but note that the macro "PM_IS_ACTIVE" is *defined* in the header file "linux/pm_legacy.h". so if that macro is still essential, its definition will have to be moved elsewhere, no? my approach was to rip out everything that seemed to be related to pm_legacy.h, so if that macro disappears, then any references to it must similarly disappear. can someone clarify this? if only one of APM or ACPI can be enabled, they should find a way to agree on that without needing legacy code to do it. rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page ========================================================================