From: Hugh Dickins <hugh@veritas.com>
To: David Rientjes <rientjes@google.com>
Cc: Zachary Amsden <zach@vmware.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch -mm] i386: use pte_update_defer in ptep_test_and_clear_{dirty,young}
Date: Mon, 16 Apr 2007 20:04:29 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0704161956510.13584@blonde.wat.veritas.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0704161139020.12097@chino.kir.corp.google.com>
On Mon, 16 Apr 2007, David Rientjes wrote:
>
> > Compromise patch below: would that be satisfactory to you, David?
>
> I really like the patch, but for perhaps a slightly different reason:
> we're only flushing ranges that have been shown to need it. We aren't
> completely flushing the entire mm which is likely to be excessive in
> situations where we're actually using /proc/pid/clear_refs in combination
> with /proc/pid/smaps for memory footprint approximation (i.e. it's on a
> fine granularity).
It would be more of a reason to like the patch, if more architectures
actually implemented flush_tlb_range as anything different from
flush_tlb_mm ;) Sadly, few can do better than flush_tlb_mm: ia64
is the exception I remember, and maybe a couple of others. I put
flush_tlb_range there merely because it seems more appropriate,
but it's rather deceptive.
Hugh
next prev parent reply other threads:[~2007-04-16 19:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-26 6:37 David Rientjes
2007-03-26 9:08 ` Andrew Morton
2007-03-26 20:24 ` Zachary Amsden
2007-04-13 17:54 ` Hugh Dickins
2007-04-13 19:05 ` Zachary Amsden
2007-04-13 19:27 ` Zachary Amsden
2007-04-13 20:24 ` Hugh Dickins
2007-04-13 20:59 ` Zachary Amsden
2007-04-16 17:59 ` Hugh Dickins
2007-04-16 18:51 ` David Rientjes
2007-04-16 19:04 ` Hugh Dickins [this message]
2007-04-16 19:20 ` David Rientjes
2007-04-16 22:08 ` Zachary Amsden
2007-04-16 22:00 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0704161956510.13584@blonde.wat.veritas.com \
--to=hugh@veritas.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®