mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Christoph Lameter <clameter@engr.sgi.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] fix OOM killing processes wrongly thought MPOL_BIND
Date: Wed, 18 Apr 2007 20:35:22 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0704182022440.11100@blonde.wat.veritas.com> (raw)

I only have CONFIG_NUMA=y for build testing: surprised when trying a memhog
to see lots of other processes killed with "No available memory (MPOL_BIND)".
memhog is killed correctly once we initialize nodemask in constrained_alloc().

Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
Perhaps appropriate for 2.6.20-stable too - regression since 2.6.19.

 mm/oom_kill.c |    2 ++
 1 file changed, 2 insertions(+)

--- 2.6.21-rc7/mm/oom_kill.c	2007-03-26 07:30:54.000000000 +0100
+++ linux/mm/oom_kill.c	2007-04-18 20:18:21.000000000 +0100
@@ -176,6 +176,8 @@ static inline int constrained_alloc(stru
 	struct zone **z;
 	nodemask_t nodes;
 	int node;
+
+	nodes_clear(nodes);
 	/* node has memory ? */
 	for_each_online_node(node)
 		if (NODE_DATA(node)->node_present_pages)

             reply	other threads:[~2007-04-18 19:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-18 19:35 Hugh Dickins [this message]
2007-04-18 21:11 ` Christoph Lameter
2007-04-18 21:23 ` William Lee Irwin III
2007-04-19  0:29 ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0704182022440.11100@blonde.wat.veritas.com \
    --to=hugh@veritas.com \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@engr.sgi.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®