From: Christoph Lameter <clameter@sgi.com>
To: Neil Brown <neilb@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: SLUB: kmem_cache_destroy doesn't - version 2.
Date: Thu, 19 Apr 2007 22:51:05 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0704192249070.17171@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0704192236510.16503@schroedinger.engr.sgi.com>
Another approach drop the symlinks completely. Just
write a message to the syslog informing the user that we
created an alias. If debugging is off then the user would have to consult
the syslog to find aliases.
Index: linux-2.6.21-rc6/mm/slub.c
===================================================================
--- linux-2.6.21-rc6.orig/mm/slub.c 2007-04-19 22:46:20.000000000 -0700
+++ linux-2.6.21-rc6/mm/slub.c 2007-04-19 22:48:26.000000000 -0700
@@ -158,11 +158,9 @@ LIST_HEAD(slab_caches);
#ifdef CONFIG_SYSFS
static int sysfs_slab_add(struct kmem_cache *);
-static int sysfs_slab_alias(struct kmem_cache *, const char *);
static void sysfs_slab_remove(struct kmem_cache *);
#else
static int sysfs_slab_add(struct kmem_cache *s) { return 0; }
-static int sysfs_slab_alias(struct kmem_cache *s, const char *p) { return 0; }
static void sysfs_slab_remove(struct kmem_cache *s) {}
#endif
@@ -2324,8 +2322,8 @@ struct kmem_cache *kmem_cache_create(con
*/
s->objsize = max(s->objsize, (int)size);
s->inuse = max_t(int, s->inuse, ALIGN(size, sizeof(void *)));
- if (sysfs_slab_alias(s, name))
- goto err;
+ printk(KERN_INFO "SLUB: %s is an alias of %s\n",
+ name, s->name);
} else {
s = kmalloc(kmem_size, GFP_KERNEL);
if (s && kmem_cache_open(s, GFP_KERNEL, name,
@@ -3335,37 +3333,6 @@ static void sysfs_slab_remove(struct kme
kobject_del(&s->kobj);
}
-/*
- * Need to buffer aliases during bootup until sysfs becomes
- * available lest we loose that information.
- */
-struct saved_alias {
- struct kmem_cache *s;
- const char *name;
- struct saved_alias *next;
-};
-
-struct saved_alias *alias_list;
-
-static int sysfs_slab_alias(struct kmem_cache *s, const char *name)
-{
- struct saved_alias *al;
-
- if (slab_state == SYSFS)
- return sysfs_create_link(&slab_subsys.kset.kobj,
- &s->kobj, name);
-
- al = kmalloc(sizeof(struct saved_alias), GFP_KERNEL);
- if (!al)
- return -ENOMEM;
-
- al->s = s;
- al->name = name;
- al->next = alias_list;
- alias_list = al;
- return 0;
-}
-
int __init slab_sysfs_init(void)
{
int err;
@@ -3378,15 +3345,6 @@ int __init slab_sysfs_init(void)
finish_bootstrap();
- while (alias_list) {
- struct saved_alias *al = alias_list;
-
- alias_list = alias_list->next;
- err = sysfs_slab_alias(al->s, al->name);
- BUG_ON(err);
- kfree(al);
- }
-
resiliency_test();
return 0;
}
next prev parent reply other threads:[~2007-04-20 5:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-20 4:28 Neil Brown
2007-04-20 5:18 ` Christoph Lameter
2007-04-20 5:35 ` Neil Brown
2007-04-20 5:38 ` Christoph Lameter
2007-04-20 5:51 ` Christoph Lameter [this message]
2007-04-23 6:44 ` Neil Brown
2007-04-23 6:48 ` Christoph Lameter
2007-04-23 20:49 ` Christoph Lameter
2007-04-24 0:34 ` Neil Brown
2007-04-24 0:42 ` Christoph Lameter
2007-04-24 0:50 ` Neil Brown
2007-04-24 1:06 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0704192249070.17171@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®