From: Christoph Lameter <clameter@sgi.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: slab allocators: Remove SLAB_DEBUG_INITIAL flag
Date: Sun, 22 Apr 2007 23:20:00 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0704222318010.2338@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20070422230841.7d99ebb1.akpm@linux-foundation.org>
On Sun, 22 Apr 2007, Andrew Morton wrote:
> This patch causes a use-uninitialised crash in the locks code.
Sigh. The only case in which the check is inverted in a constructor.
Invert the check.
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Index: linux-2.6.21-rc6/fs/locks.c
===================================================================
--- linux-2.6.21-rc6.orig/fs/locks.c 2007-04-22 23:17:29.000000000 -0700
+++ linux-2.6.21-rc6/fs/locks.c 2007-04-22 23:17:45.000000000 -0700
@@ -203,7 +203,7 @@ static void init_once(void *foo, struct
{
struct file_lock *lock = (struct file_lock *) foo;
- if (flags & SLAB_CTOR_CONSTRUCTOR)
+ if (!(flags & SLAB_CTOR_CONSTRUCTOR))
return;
locks_init_lock(lock);
prev parent reply other threads:[~2007-04-23 6:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-21 1:39 Christoph Lameter
2007-04-23 6:08 ` Andrew Morton
2007-04-23 6:20 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0704222318010.2338@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®