mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH][RFC] Allow the i386 install.sh script to try the generic installkernel.
Date: Tue, 1 May 2007 03:52:53 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0705010345460.8080@localhost.localdomain> (raw)


Allow the install script arch/i386/boot/install.sh to fall back to try
the generic "installkernel" command if a CROSS_COMPILE version isn't
available.

Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

---

the rationale here:

  after cross-compiling the kernel for x86_64, i (accidentally) left
the CROSS_COMPILE variable on the make line when i tried to install
the kernel:

  # make ARCH=x86_64 CROSS_COMPILE=x86_64- install

as you can see, if you don't have a custom version, the install script
will eventually try to run lilo.  barf.

  is it reasonable, after you check for the custom version, to drop
down and try the generic version (which would have worked just
fine)?

  or is there a cleaner solution?  or is this the correct logic after
all?


diff --git a/arch/i386/boot/install.sh b/arch/i386/boot/install.sh
index 5e44c73..2f7c970 100644
--- a/arch/i386/boot/install.sh
+++ b/arch/i386/boot/install.sh
@@ -38,6 +38,11 @@ verify "$3"
 if [ -x ~/bin/${CROSS_COMPILE}installkernel ]; then exec ~/bin/${CROSS_COMPILE}installkernel "$@"; fi
 if [ -x /sbin/${CROSS_COMPILE}installkernel ]; then exec /sbin/${CROSS_COMPILE}installkernel "$@"; fi

+# OK, then, let's try the generic installkernel scripts.
+
+if [ -x ~/bin/installkernel ]; then exec ~/bin/installkernel "$@"; fi
+if [ -x /sbin/installkernel ]; then exec /sbin/installkernel "$@"; fi
+
 # Default install - same as make zlilo

 if [ -f $4/vmlinuz ]; then

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

                 reply	other threads:[~2007-05-01  7:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0705010345460.8080@localhost.localdomain \
    --to=rpjday@mindspring.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®