From: Geert Uytterhoeven <geert@linux-m68k.org>
To: David Howells <dhowells@redhat.com>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [AF_RXRPC]: Make the in-kernel AFS filesystem use AF_RXRPC.
Date: Tue, 1 May 2007 18:31:07 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0705011820180.27246@anakin> (raw)
In-Reply-To: <9374.1178036083@redhat.com>
On Tue, 1 May 2007, David Howells wrote:
> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > This causes a compile failure on m68k:
>
> Hmmm... I couldn't actually test m68k as I couldn't get it to compile. Can
> you give me a good config I can use as a base?
>
> > | linux/fs/afs/fsclient.c: In function 'afs_deliver_fs_fetch_data':
> > | linux/fs/afs/fsclient.c:269: warning: dereferencing 'void *' pointer
> > | linux/fs/afs/fsclient.c:269: error: request for member 'virtual' in something not a structure or union
>
> Ummm... Maybe m68k kmap_atomic() should cast it... I think everywhere else
> it must be an inline function or something.
On architectures that #define WANT_PAGE_VIRTUAL (frv/m68k/mips/extensa),
page_address(page) expands to (page)->virtual, which fails if page is a
void *.
> However, I'll subsume your patch into mine if you don't mind.
Please apply ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2007-05-01 16:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200704271707.l3RH7H5Z032671@hera.kernel.org>
2007-05-01 15:41 ` Geert Uytterhoeven
2007-05-01 16:23 ` Linus Torvalds
2007-05-01 17:51 ` Geert Uytterhoeven
2007-05-01 16:14 ` David Howells
2007-05-01 16:31 ` Geert Uytterhoeven [this message]
2007-05-01 16:58 ` David Howells
2007-05-01 17:52 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0705011820180.27246@anakin \
--to=geert@linux-m68k.org \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®