From: Kumar Gala <galak@kernel.crashing.org>
To: Simon Horman <horms@verge.net.au>
Cc: "Timur Tabi" <timur@freescale.com>,
"Kim Phillips" <kim.phillips@freescale.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"Ismail Dönmez" <ismail@pardus.org.tr>,
"Michael Schmitz" <schmitz@debian.org>,
"Roman Zippel" <zippel@linux-m68k.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>
Subject: Re: Kconfig warnings on latest GIT
Date: Thu, 10 May 2007 20:47:05 -0500 (CDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0705102046400.10555@gate.crashing.org> (raw)
In-Reply-To: <20070511012529.GC10715@verge.net.au>
On Fri, 11 May 2007, Simon Horman wrote:
> On Thu, May 10, 2007 at 11:56:48AM -0500, Timur Tabi wrote:
> > Simon Horman wrote:
> >
> > >>So my question is: in which Kconfig do I define "UCC_FAST_TEMP" and
> > >>"UCC_SLOW_TEMP"? At first I thought, just put it in drivers/Kconfig, but
> > >>that Kconfig does nothing but including other Kconfigs. I believe that if I
> > >>submit a patch that adds "UCC_FAST_TEMP" and "UCC_SLOW_TEMP" to
> > >>drivers/Kconfig, it will be rejected. Either that, or I'll spend six weeks
> > >>trying to persuade everyone that it's a good idea.
> > >>
> > >>Does anyone have any suggestions on how I can fix this?
> > >That does seem like a reasonable suggestion, and one that
> > >would probably work well with the other similar problems
> > >that have been introduced sice 2.6.21.
> >
> > Looks like the fix is simpler than I thought. Instead of having
> >
> > UCC_GETH
> > select UCC_FAST
> >
> > I need to do
> >
> > UCC_FAST
> > default y if UCC_GETH
>
> I pondered something like that, but I couldn't get it quite right :(
>
> > I'll have a patch that fixes this out later today.
> >
> > I chose the first method because I wanted each individual UCC device
> > driver to select UCC_FAST or UCC_SLOW as appropriate, so that I
> > wouldn't have to update arch/powerpc/sysdev/qe_lib/Kconfig every time
> > we add a new UCC driver. Oh well.
>
> --
> Horms
> H: http://www.vergenet.net/~horms/
> W: http://www.valinux.co.jp/en/
>
Try this patch:
diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig b/arch/powerpc/sysdev/qe_lib/Kconfig
index 887739f..5de7aba 100644
--- a/arch/powerpc/sysdev/qe_lib/Kconfig
+++ b/arch/powerpc/sysdev/qe_lib/Kconfig
@@ -12,6 +12,7 @@ config UCC_SLOW
config UCC_FAST
bool
+ default y if UCC_GETH
default n
select UCC
help
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index fa489b1..b159c6c 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2276,7 +2276,6 @@ config GFAR_NAPI
config UCC_GETH
tristate "Freescale QE Gigabit Ethernet"
depends on QUICC_ENGINE
- select UCC_FAST
help
This driver supports the Gigabit Ethernet mode of the QUICC Engine,
which is available on some Freescale SOCs.
next prev parent reply other threads:[~2007-05-11 1:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 21:04 Ismail Dönmez
2007-05-08 19:31 ` Kim Phillips
2007-05-08 20:11 ` Timur Tabi
2007-05-10 5:10 ` Simon Horman
2007-05-10 15:39 ` Johannes Berg
2007-05-11 1:22 ` Simon Horman
2007-05-11 11:45 ` Johannes Berg
2007-05-14 1:32 ` Simon Horman
2007-05-14 12:55 ` Johannes Berg
2007-05-14 14:24 ` Kumar Gala
2007-05-14 16:25 ` Johannes Berg
2007-05-23 12:37 ` Kumar Gala
2007-05-23 13:57 ` Johannes Berg
2007-05-23 14:14 ` Kumar Gala
2007-05-23 14:26 ` Johannes Berg
2007-05-10 16:56 ` Timur Tabi
2007-05-11 1:25 ` Simon Horman
2007-05-11 1:41 ` Kumar Gala
2007-05-11 1:47 ` Kumar Gala [this message]
2007-05-11 2:05 ` Simon Horman
2007-05-11 2:13 ` Kumar Gala
2007-05-11 2:27 ` Simon Horman
2007-05-11 2:32 ` Timur Tabi
2007-05-11 3:08 ` Simon Horman
2007-05-11 7:43 ` Russell King
2007-05-11 12:38 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0705102046400.10555@gate.crashing.org \
--to=galak@kernel.crashing.org \
--cc=benh@kernel.crashing.org \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=ismail@pardus.org.tr \
--cc=johannes@sipsolutions.net \
--cc=kim.phillips@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=schmitz@debian.org \
--cc=timur@freescale.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®