From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757757AbXEMK2f (ORCPT ); Sun, 13 May 2007 06:28:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757214AbXEMK22 (ORCPT ); Sun, 13 May 2007 06:28:28 -0400 Received: from astra.telenet-ops.be ([195.130.132.58]:54026 "EHLO astra.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757132AbXEMK21 (ORCPT ); Sun, 13 May 2007 06:28:27 -0400 Date: Sun, 13 May 2007 12:28:23 +0200 (CEST) From: Geert Uytterhoeven To: Davide Libenzi Cc: Linux Kernel Mailing List , Andrew Morton , Linus Torvalds , Oleg Nesterov , "Eric W. Biederman" Subject: undefined reference to `__clear_user' (was: Re: [patch 2/13] signal/timer/event fds v10 - signalfd core ...) In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi Davide, On Mon, 2 Apr 2007, Davide Libenzi wrote: > --- /dev/null 1970-01-01 00:00:00.000000000 +0000 > +++ linux-2.6.21-rc5.fds/fs/signalfd.c 2007-04-02 15:06:29.000000000 -0700 > +/* > + * Copied from copy_siginfo_to_user() in kernel/signal.c > + */ > +static int signalfd_copyinfo(struct signalfd_siginfo __user *uinfo, > + siginfo_t const *kinfo) > +{ > + long err; > + > + BUILD_BUG_ON(sizeof(struct signalfd_siginfo) != 128); > + > + /* > + * Unused memebers should be zero ... > + */ > + err = __clear_user(uinfo, sizeof(*uinfo)); ^^^^^^^^^^^^ Shouldn't this be `clear_user()'? I don't see any access_ok() calls before this call (I do see them in copy_siginfo_to_user() in kernel/signal.c), but of course I may miss something... I only noticed because m68k doesn't have __clear_user(), as this routine was never needed by generic code before your change. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds