From: Hugh Dickins <hugh@veritas.com>
To: Andi Kleen <ak@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <clameter@sgi.com>,
William Lee Irwin III <wli@holomorphy.com>,
David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: [PATCH] i386: don't check_pgt_cache in flush_tlb_mm
Date: Tue, 15 May 2007 19:51:05 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0705151946550.30826@blonde.wat.veritas.com> (raw)
No other architecture calls check_pgt_cache() from within flush_tlb_mm(),
and i386 is already calling check_pgt_cache() from the usual places,
tlb_finish_mmu() and cpu_idle() (the latter being odd, but not unusual).
flush_tlb_mm() has no business to be freeing pages: remove that line,
which sneaked in with slub's i386 support.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
arch/i386/kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 2.6.22-rc1/arch/i386/kernel/smp.c 2007-05-13 05:40:51.000000000 +0100
+++ linux/arch/i386/kernel/smp.c 2007-05-15 17:49:48.000000000 +0100
@@ -421,7 +421,7 @@ void flush_tlb_mm (struct mm_struct * mm
}
if (!cpus_empty(cpu_mask))
flush_tlb_others(cpu_mask, mm, TLB_FLUSH_ALL);
- check_pgt_cache();
+
preempt_enable();
}
next reply other threads:[~2007-05-15 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 18:51 Hugh Dickins [this message]
2007-05-15 18:55 ` Christoph Lameter
2007-05-15 18:59 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0705151946550.30826@blonde.wat.veritas.com \
--to=hugh@veritas.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®