From: Roman Zippel <zippel@linux-m68k.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Elimar Riesebieter <riesebie@lxtec.de>,
mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: 2.6.22-rc2 built on ppc (2)
Date: Mon, 21 May 2007 03:54:00 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0705210344130.1817@scrub.home> (raw)
In-Reply-To: <20070520143752.2f6be87a.akpm@linux-foundation.org>
Hi,
On Sun, 20 May 2007, Andrew Morton wrote:
> On Sun, 20 May 2007 13:08:15 +0200 Elimar Riesebieter <riesebie@lxtec.de> wrote:
>
> > FYI, building 2.6.22-rc2 with
> > gcc (GCC) 4.1.3 20070514 (prerelease) (Debian 4.1.2-7)
> > on my powerbook (PPC) gives:
> >
> > ...
> > kernel/time/ntp.c: In function 'do_adjtimex':
> > kernel/time/ntp.c:307: warning: comparison of distinct pointer types lacks a cast
> > kernel/time/ntp.c:310: warning: comparison of distinct pointer types lacks a cast
>
> hm, do_div() is defined as operating on a u64, but ntp is passing it an s64
> and the asm-generic implementation of do_div() is warning about that.
>
> Fixing that would be simple but a bit ugly.
The correct fix would be to clean up that API and provide a signed
do_div(), so ntp doesn't have to work around for the lack of it.
It's on my todo list for ages, but I haven't gotten to it yet.
bye, Roman
next prev parent reply other threads:[~2007-05-21 1:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-20 11:08 Elimar Riesebieter
2007-05-20 21:37 ` Andrew Morton
2007-05-21 1:54 ` Roman Zippel [this message]
2007-05-21 10:03 ` Thomas Gleixner
2007-05-21 10:25 ` Roman Zippel
2007-05-21 10:40 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0705210344130.1817@scrub.home \
--to=zippel@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=riesebie@lxtec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®