From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966755AbXEVSzd (ORCPT ); Tue, 22 May 2007 14:55:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760628AbXEVSzZ (ORCPT ); Tue, 22 May 2007 14:55:25 -0400 Received: from netops-testserver-4-out.sgi.com ([192.48.171.29]:51289 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758895AbXEVSzY (ORCPT ); Tue, 22 May 2007 14:55:24 -0400 Date: Tue, 22 May 2007 11:55:23 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Fenghua Yu cc: akpm@linux-foundation.org, suresh.b.siddha@intel.com, kiran@scalex86.org, rmk@arm.linux.org.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] Use the new percpu interface for shared data -- version 3 In-Reply-To: <20070522182022.GA27317@linux-os.sc.intel.com> Message-ID: References: <1162040333.1178030136225.JavaMail.was6@nci57003d.marriott.com> <20070522182022.GA27317@linux-os.sc.intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 22 May 2007, Fenghua Yu wrote: > -DEFINE_PER_CPU(struct tss_struct, init_tss) ____cacheline_internodealigned_in_smp = INIT_TSS; > +DEFINE_PER_CPU_SHARED_ALIGNED(struct tss_struct, init_tss) = INIT_TSS; Good work but could we call this something shorter? Like DEFINE_CPU_SHARED(...)