From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Tim Hockin <thockin@google.com>
Cc: Roland Dreier <rdreier@cisco.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Kconfig variable "COBALT" is not defined anywhere
Date: Sun, 3 Jun 2007 17:50:26 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0706031747190.23873@localhost.localdomain> (raw)
In-Reply-To: <cc96a5040706031438o667e4df0wb18bdd071f48e246@mail.gmail.com>
On Sun, 3 Jun 2007, Tim Hockin wrote:
> I think the nvram is the only place left that uses CONFIG_COBALT
sure, but once you remove this snippet near the top of
drivers/char/nvram.c:
...
# if defined(CONFIG_COBALT)
# include <linux/cobalt-nvram.h>
# define MACH COBALT
# else
# define MACH PC
# endif
...
then everything else COBALT-related in that file should be tossed as
well, which would include stuff conditional on:
#if MACH == COBALT
and so on. just making sure that what you're saying is that *all*
COBALT-related content in that file can be thrown out. i'll submit a
patch shortly and you can pass judgment.
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
next prev parent reply other threads:[~2007-06-03 21:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-03 17:17 Robert P. J. Day
2007-06-03 20:23 ` Randy Dunlap
2007-06-03 20:31 ` Robert P. J. Day
2007-06-03 20:45 ` Roland Dreier
2007-06-03 21:08 ` Tim Hockin
2007-06-03 21:15 ` Robert P. J. Day
2007-06-03 21:38 ` Tim Hockin
2007-06-03 21:50 ` Robert P. J. Day [this message]
2007-06-04 3:15 ` Tim Hockin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0706031747190.23873@localhost.localdomain \
--to=rpjday@mindspring.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
--cc=thockin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®