From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937813AbXFHFWQ (ORCPT ); Fri, 8 Jun 2007 01:22:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763386AbXFHFWF (ORCPT ); Fri, 8 Jun 2007 01:22:05 -0400 Received: from x35.xmailserver.org ([64.71.152.41]:4536 "EHLO x35.xmailserver.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758912AbXFHFWD (ORCPT ); Fri, 8 Jun 2007 01:22:03 -0400 X-AuthUser: davidel@xmailserver.org Date: Thu, 7 Jun 2007 22:22:01 -0700 (PDT) From: Davide Libenzi X-X-Sender: davide@alien.or.mcafeemobile.com To: Eric Dumazet cc: Linux Kernel Mailing List , Linus Torvalds , Andrew Morton , Ulrich Drepper , Ingo Molnar Subject: Re: [patch 1/8] fdmap v2 - fdmap core In-Reply-To: <4668E25D.3010109@cosmosbay.com> Message-ID: References: <4668E106.9040509@cosmosbay.com> <4668E25D.3010109@cosmosbay.com> X-GPG-FINGRPRINT: CFAE 5BEE FD36 F65E E640 56FE 0974 BF23 270F 474E X-GPG-PUBLIC_KEY: http://www.xmailserver.org/davidel.asc MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Jun 2007, Eric Dumazet wrote: > Well, offsets are wrong but layout OK > > struct fd_map { > /* > * read mostly part > */ > unsigned int base; /* 0x00 */ > unsigned int size; /* 0x04 */ > struct list_head slist; /* 0x08 */ > struct list_head *slots; /* 0x18 */ > unsigned long *map; /* 0x20 */ > void (*freecb)(void *, struct fd_map *); /* 0x28 */ > void *freecb_priv; /* 0x30 */ > /* one 8 bytes hole */ > > /* > * written part on a separate cache line in SMP > */ > unsigned int fdnext ____cacheline_aligned_in_smp; /* 0x40 */ > > struct fd_map *next; /* 0x48 */ > struct rcu_head rcu; /* 0x50 */ > }; /* size 0x60 , aligned to 0x80 */ There's a new "unsigned int count" now. That hole just calls for it ;) - Davide