From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>
Subject: [PATCH] Include <asm/termbits.h> from <linux/tty_driver.h>.
Date: Fri, 8 Jun 2007 09:29:12 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0706080925020.24228@localhost.localdomain> (raw)
The header file <linux/tty_driver.h> should include <asm/termbits.h>
to pick up the definition of "struct ktermios"; otherwise, you run the
risk of seeing:
include/linux/tty_driver.h:142: warning: 'struct ktermios' \
declared inside parameter list
include/linux/tty_driver.h:142: warning: its scope is only \
this definition or declaration, which is probably not what you want
Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
---
i'm *guessing* this is the solution to the above issue.
diff --git a/include/linux/tty_driver.h b/include/linux/tty_driver.h
index 85c95cd..b687174 100644
--- a/include/linux/tty_driver.h
+++ b/include/linux/tty_driver.h
@@ -123,6 +123,7 @@
#include <linux/fs.h>
#include <linux/list.h>
#include <linux/cdev.h>
+#include <asm/termbits.h>
struct tty_struct;
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
next reply other threads:[~2007-06-08 13:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 13:29 Robert P. J. Day [this message]
2007-06-08 15:30 ` Alan Cox
2007-06-08 15:27 ` Jan Engelhardt
2007-06-08 15:34 ` Robert P. J. Day
2007-06-08 15:45 ` Alan Cox
2007-06-08 15:42 ` Robert P. J. Day
2007-06-08 16:53 ` Jan Engelhardt
2007-06-08 15:29 ` Robert P. J. Day
2007-06-08 15:48 ` Alan Cox
2007-06-08 15:46 ` Robert P. J. Day
2007-06-08 15:57 ` Alan Cox
2007-06-08 16:15 ` Robert P. J. Day
2007-06-08 16:24 ` Alan Cox
2007-06-08 16:27 ` Robert P. J. Day
2007-06-08 16:41 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0706080925020.24228@localhost.localdomain \
--to=rpjday@mindspring.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®