mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: "Håvard Skinnemoen" <hskinnemoen@gmail.com>
Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: kernel BUG at mm/slub.c:3689!
Date: Mon, 11 Jun 2007 11:32:33 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0706111129270.18327@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <1defaf580706111122n78ab46c3sda05cbd4ace97319@mail.gmail.com>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1064 bytes --]

On Mon, 11 Jun 2007, Håvard Skinnemoen wrote:

> > Note that I do not get why you would be aligning the objects to 32 bytes.
> > Increasing the smallest cache size wastes a lot of memory. And it is
> > usually advantageous if multiple related objects are in the same cacheline
> > unless you have heavy SMP contention.
> 
> It's not about performance at all, it's about DMA buffers allocated
> using kmalloc() getting corrupted. Imagine this:

Uhhh... How about using a separate slab for the DMA buffers?
 
> Maybe there are other solutions to this problem, but the old SLAB
> allocator did guarantee 32-byte alignment as long as SLAB debugging
> was turned off, so setting ARCH_KMALLOC_MINALIGN seemed like the
> easiest way to get back to the old, known-working behaviour.

SLABs mininum object size is 32 thus you had no problems. I see. SLAB 
does not guarantee 32 byte alignment. It just happened to work. If you 
switch on CONFIG_SLAB_DEBUG you will likely get into trouble.

So I'd suggest to set up a special slab for your DMA buffers.

  reply	other threads:[~2007-06-11 18:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-11 14:19 Haavard Skinnemoen
2007-06-11 15:38 ` Paul Mundt
2007-06-11 15:58   ` Håvard Skinnemoen
2007-06-11 16:19 ` Christoph Lameter
2007-06-11 16:43   ` Håvard Skinnemoen
2007-06-11 16:49     ` Christoph Lameter
2007-06-11 17:11       ` Håvard Skinnemoen
2007-06-11 17:52         ` Christoph Lameter
2007-06-11 18:22           ` Håvard Skinnemoen
2007-06-11 18:32             ` Christoph Lameter [this message]
2007-06-11 19:04               ` Håvard Skinnemoen
2007-06-11 19:11                 ` Christoph Lameter
2007-06-11 19:35                   ` Håvard Skinnemoen
2007-06-11 19:40                     ` Christoph Lameter
2007-06-11 19:53                       ` Håvard Skinnemoen
2007-06-12  3:16                         ` Christoph Lameter
2007-06-12  8:55                           ` Haavard Skinnemoen
2007-06-12 10:16                             ` Haavard Skinnemoen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0706111129270.18327@schroedinger.engr.sgi.com \
    --to=clameter@sgi.com \
    --cc=hskinnemoen@atmel.com \
    --cc=hskinnemoen@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®