From: Christoph Lameter <clameter@sgi.com>
To: Cedric Le Goater <clg@fr.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Herbert Poetzl <herbert@13thfloor.at>,
Pavel Emelianov <xemul@openvz.org>
Subject: Re: [PATCH -mm] add a kmem_cache for nsproxy objects
Date: Fri, 22 Jun 2007 09:22:56 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0706220920190.16635@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <467B7EB6.4050207@fr.ibm.com>
On Fri, 22 Jun 2007, Cedric Le Goater wrote:
> the macro sets the align parameter to "__alignof__(struct)" by default.
> is that something we want to do all the time ? if so, why not change
> kmem_cache_create() directly ?
Its a safety net. If there is some reason that the structure needs a
larger alignment than ARCH_KMALLOC_MINALIGN then that alignment will be
applied.
> Most of the complexity is in flags. I did a grep and picked what i thought
> was the most aggressive. The macro would probably be more useful if we could
> identify by it's name in which context it can be used.
What context are you thinking about and how would it influence
the macro?
prev parent reply other threads:[~2007-06-22 16:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-18 20:53 Cedric Le Goater
2007-06-19 18:35 ` Andrew Morton
2007-06-19 19:04 ` Christoph Hellwig
2007-06-19 19:27 ` Christoph Lameter
2007-06-19 21:14 ` Pekka Enberg
2007-06-19 19:24 ` Christoph Lameter
2007-06-22 7:48 ` Cedric Le Goater
2007-06-22 16:22 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0706220920190.16635@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=clg@fr.ibm.com \
--cc=herbert@13thfloor.at \
--cc=linux-kernel@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®